fix: prune double leading slash in favicon url

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>

layouts/_default/engine-api-baseof.html

@@ -9,11 +9,7 @@
         content="Reference documentation and Swagger (OpenAPI) specification for the {{ .File.BaseFileName }} version of the API served by Docker Engine." />
     <meta charset="utf-8" />
     <!-- favicon -->
-    <meta name="msapplication-TileImage" content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" />
-    <meta property="og:image" content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" />
-    <link rel="apple-touch-icon" type="image/x-icon" href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
-        sizes="129x128" />
-    <link rel="icon" type="image/x-icon" href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" sizes="129x128" />
+    {{ partialCached "favicon.html" "favicon" }}
     <!-- make the latest API version the canonical page as that's what we want users to be using mostly -->
     <link rel="canonical" href="{{ site.BaseURL }}/engine/api/v{{ site.Params.latest_engine_api_version }}/" />
     <style>

layouts/_default/hub-api-baseof.html

@@ -9,11 +9,7 @@
     content="Reference documentation and Swagger (OpenAPI) specification for the {{ .File.BaseFileName }} API served by Docker Hub." />
   <meta charset="utf-8" />
   <!-- favicon -->
-  <meta name="msapplication-TileImage" content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" />
-  <meta property="og:image" content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" />
-  <link rel="apple-touch-icon" type="image/x-icon" href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
-    sizes="129x128" />
-  <link rel="icon" type="image/x-icon" href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico" sizes="129x128" />
+  {{ partialCached "favicon.html" "favicon" }}
   <!-- make the latest API version the canonical page as that's what we want users to be using mostly -->
   <link rel="canonical" href="{{ site.BaseURL }}/docker-hub/api/latest/" />
   <style>

layouts/partials/favicon.html

@@ -0,0 +1,17 @@
+{{- $favicon := resources.Get "favicons/docs@2x.ico" }}
+<link
+  rel="icon"
+  type="image/x-icon"
+  href="{{ $favicon.Permalink }}"
+  sizes="129x128"
+/>
+<link
+  rel="apple-touch-icon"
+  type="image/x-icon"
+  href="{{ $favicon.Permalink }}"
+  sizes="129x128"
+/>
+<meta
+  name="msapplication-TileImage"
+  content="{{ $favicon.Permalink }}"
+/>

layouts/partials/meta.html

@@ -18,22 +18,7 @@
 <link rel="canonical" href="{{ .Permalink }}" />
 
 <!-- favicon -->
-<link
-  rel="icon"
-  type="image/x-icon"
-  href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
-  sizes="129x128"
-/>
-<link
-  rel="apple-touch-icon"
-  type="image/x-icon"
-  href="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
-  sizes="129x128"
-/>
-<meta
-  name="msapplication-TileImage"
-  content="{{ site.BaseURL }}/assets/favicons/docs@2x.ico"
-/>
+{{ partialCached "favicon.html" "favicon" }}
 <meta name="theme-color" content="#2496ed" />
 
 <!-- SEO -->