Merge pull request #222 from kitematic/setup-hardening

Fix error with permissions when setting up CLI tools. Better error messages and reporting

src/ContainerHome.react.js

@@ -74,7 +74,7 @@ var ContainerHome = React.createClass({
     if (this.props.error) {
       body = (
         <div className="details-progress">
-          <h3>There was a problem connecting to the Docker Engine.<br/>Either the VirtualBox VM was removed, is not responding or Docker is not running inside of it. Try restarting Kitematic. If the issue persists, please <a onClick={this.handleErrorClick}>file a ticket on our GitHub repo.</a></h3>
+          <h3>There was a problem connecting to the Docker Engine in the VirtualBox VM.<br/>This could be caused because this Mac is currently connected a VPN, blocking access to the VM. If the issue persists, please <a onClick={this.handleErrorClick}>file a ticket on our GitHub repo.</a></h3>
           <Radial progress={100} error={true} thick={true} transparent={true}/>
         </div>
       );

src/Main.js

@@ -108,6 +108,4 @@ SetupStore.setup().then(ip => {
     step: 'catch',
     error: err
   });
-  console.log(err);
-  console.log(err.stack);
 });

src/Setup.react.js

@@ -127,7 +127,7 @@ var Setup = React.createClass({
             <h4>Setup Error</h4>
             <h1>We&#39;re Sorry!</h1>
             <p>There seems to have been an unexpected error with Kitematic:</p>
-            <p className="error">{this.state.error}<br />{this.state.error.message}</p>
+            <p className="error">{this.state.error.message || this.state.error}</p>
             <p><button className="btn btn-action" disabled={this.state.retrying} onClick={this.handleErrorRetry}>Retry Setup</button></p>
           </div>
         </div>

src/SetupStore.js

@@ -115,10 +115,6 @@ var SetupStore = assign(Object.create(EventEmitter.prototype), {
   error: function () {
     return _error;
   },
-  setError: function (error) {
-    _error = error;
-    this.emit(this.ERROR_EVENT);
-  },
   cancelled: function () {
     return _cancelled;
   },
@@ -195,20 +191,7 @@ var SetupStore = assign(Object.create(EventEmitter.prototype), {
           break;
         } catch (err) {
           if (err) {
-            console.log('Setup encountered an error.');
-            console.log(err);
-            console.log(err.stack);
-            metrics.track('Setup Failed', {
-              step: step.name
-            });
-            var virtualboxVersion = virtualBox.installed() ? yield virtualBox.version() : 'Not installed';
-            bugsnag.notify('SetupError', 'Setup failed', {
-              error: err,
-              step: step.name,
-              virtualbox: virtualboxVersion
-            });
-            _error = err;
-            this.emit(this.ERROR_EVENT);
+            throw err;
           } else {
             metrics.track('Setup Cancelled');
             _cancelled = true;
@@ -223,25 +206,32 @@ var SetupStore = assign(Object.create(EventEmitter.prototype), {
   }),
   setup: Promise.coroutine(function * () {
     while (true) {
+      try {
         var ip = yield this.run();
         if (!ip || !ip.length) {
-        metrics.track('Setup Failed', {
-          step: 'done',
-          message: 'Machine IP not set'
-        });
-        var virtualboxVersion = virtualBox.installed() ? yield virtualBox.version() : 'Not installed';
-        bugsnag.notify('SetupError', 'Machine ip was not set', {
+          throw {
+            message: 'Machine IP could not be fetched. Please retry the setup. If this fails please file a ticket on our GitHub repo.',
             machine: yield machine.info(),
             ip: ip,
-          step: 'done',
-          virtualbox: virtualboxVersion
-        });
-        SetupStore.setError('Could not reach the Docker Engine inside the VirtualBox VM');
-        yield this.pause();
+          };
         } else {
           metrics.track('Setup Finished');
           return ip;
         }
+      } catch (err) {
+        metrics.track('Setup Failed', {
+          step: _currentStep
+        });
+        var virtualboxVersion = virtualBox.installed() ? yield virtualBox.version() : 'Not installed';
+        bugsnag.notify('SetupError', 'Setup failed', {
+          error: err,
+          step: _currentStep,
+          virtualbox: virtualboxVersion
+        });
+        _error = err;
+        this.emit(this.ERROR_EVENT);
+        yield this.pause();
+      }
     }
   })
 });

src/SetupUtil.js

@@ -12,7 +12,8 @@ var SetupUtil = {
     if (!fs.existsSync('/usr/local') || !fs.existsSync('/usr/local/bin')) {
       return true;
     }
-    if (!fs.existsSync('/usr/local/bin/docker') && !fs.existsSync('/usr/local/bin/docker-machine')) {
+
+    if (!fs.existsSync('/usr/local/bin/docker') || !fs.existsSync('/usr/local/bin/docker-machine')) {
       return fs.statSync('/usr/local/bin').gid !== 80 || fs.statSync('/usr/local/bin').uid !== process.getuid();
     }
 

src/Util.js

@@ -11,7 +11,7 @@ module.exports = {
         if (code) {
           var cmd = Array.isArray(args) ? args.join(' ') : args;
           reject({
-            message: cmd.replace(this.home(), '') + 'returned non zero exit code',
+            message: cmd.replace(this.home(), '') + ' returned non zero exit code',
             stderr: stderr,
             stdout: stdout
           });