From 8b02d85e1728b48729b2fb8553b2ec4b56a30d37 Mon Sep 17 00:00:00 2001 From: Antonio Murdaca Date: Mon, 23 Mar 2015 20:20:43 +0100 Subject: [PATCH] Remove hardcoded error Signed-off-by: Antonio Murdaca --- builder/evaluator.go | 7 +------ integration-cli/docker_cli_build_test.go | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/builder/evaluator.go b/builder/evaluator.go index b74c1ba6ae..aff0e4eabd 100644 --- a/builder/evaluator.go +++ b/builder/evaluator.go @@ -20,7 +20,6 @@ package builder import ( - "errors" "fmt" "io" "os" @@ -42,10 +41,6 @@ import ( "github.com/docker/docker/utils" ) -var ( - ErrDockerfileEmpty = errors.New("Dockerfile cannot be empty") -) - // Environment variable interpolation will happen on these statements only. var replaceEnvAllowed = map[string]struct{}{ command.Env: {}, @@ -225,7 +220,7 @@ func (b *Builder) readDockerfile() error { return fmt.Errorf("Cannot locate specified Dockerfile: %s", origFile) } if fi.Size() == 0 { - return ErrDockerfileEmpty + return fmt.Errorf("The Dockerfile (%s) cannot be empty", origFile) } f, err := os.Open(filename) diff --git a/integration-cli/docker_cli_build_test.go b/integration-cli/docker_cli_build_test.go index 44d6313858..239dce6e8e 100644 --- a/integration-cli/docker_cli_build_test.go +++ b/integration-cli/docker_cli_build_test.go @@ -3504,7 +3504,7 @@ func TestBuildFailsDockerfileEmpty(t *testing.T) { defer deleteImages(name) _, err := buildImage(name, ``, true) if err != nil { - if !strings.Contains(err.Error(), "Dockerfile cannot be empty") { + if !strings.Contains(err.Error(), "The Dockerfile (Dockerfile) cannot be empty") { t.Fatalf("Wrong error %v, must be about empty Dockerfile", err) } } else {