From 8cf84ea552e8fa14d26875b41b3d70d70ee7b44e Mon Sep 17 00:00:00 2001 From: Mazz Mosley Date: Wed, 1 Jul 2015 17:47:44 +0100 Subject: [PATCH] Fix missing image names These tests were indeed raising a config error, but not for the reason intended/tested for. I've added in the image name so the config error raise is correctly testing the Service name. Signed-off-by: Mazz Mosley --- tests/unit/service_test.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/unit/service_test.py b/tests/unit/service_test.py index f99cbbc9d1..fb6b56c48c 100644 --- a/tests/unit/service_test.py +++ b/tests/unit/service_test.py @@ -28,16 +28,16 @@ class ServiceTest(unittest.TestCase): self.mock_client = mock.create_autospec(docker.Client) def test_name_validations(self): - self.assertRaises(ConfigError, lambda: Service(name='')) + self.assertRaises(ConfigError, lambda: Service(name='', image='foo')) - self.assertRaises(ConfigError, lambda: Service(name=' ')) - self.assertRaises(ConfigError, lambda: Service(name='/')) - self.assertRaises(ConfigError, lambda: Service(name='!')) - self.assertRaises(ConfigError, lambda: Service(name='\xe2')) - self.assertRaises(ConfigError, lambda: Service(name='_')) - self.assertRaises(ConfigError, lambda: Service(name='____')) - self.assertRaises(ConfigError, lambda: Service(name='foo_bar')) - self.assertRaises(ConfigError, lambda: Service(name='__foo_bar__')) + self.assertRaises(ConfigError, lambda: Service(name=' ', image='foo')) + self.assertRaises(ConfigError, lambda: Service(name='/', image='foo')) + self.assertRaises(ConfigError, lambda: Service(name='!', image='foo')) + self.assertRaises(ConfigError, lambda: Service(name='\xe2', image='foo')) + self.assertRaises(ConfigError, lambda: Service(name='_', image='foo')) + self.assertRaises(ConfigError, lambda: Service(name='____', image='foo')) + self.assertRaises(ConfigError, lambda: Service(name='foo_bar', image='foo')) + self.assertRaises(ConfigError, lambda: Service(name='__foo_bar__', image='foo')) Service('a', image='foo') Service('foo', image='foo')