From eeb568fd270cd62a376db673b37d202079539a2a Mon Sep 17 00:00:00 2001 From: David Gageot Date: Tue, 8 Dec 2015 10:09:02 +0100 Subject: [PATCH] FIX 2510 Support DNS names Signed-off-by: David Gageot --- libmachine/drivers/base.go | 6 ------ libmachine/drivers/base_test.go | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/libmachine/drivers/base.go b/libmachine/drivers/base.go index 38dd106581..6612e6b88a 100644 --- a/libmachine/drivers/base.go +++ b/libmachine/drivers/base.go @@ -2,8 +2,6 @@ package drivers import ( "errors" - "fmt" - "net" "path/filepath" ) @@ -41,10 +39,6 @@ func (d *BaseDriver) GetIP() (string, error) { if d.IPAddress == "" { return "", errors.New("IP address is not set") } - ip := net.ParseIP(d.IPAddress) - if ip == nil { - return "", fmt.Errorf("IP address is invalid: %s", d.IPAddress) - } return d.IPAddress, nil } diff --git a/libmachine/drivers/base_test.go b/libmachine/drivers/base_test.go index 1426482b6f..0378c7f0a2 100644 --- a/libmachine/drivers/base_test.go +++ b/libmachine/drivers/base_test.go @@ -2,7 +2,6 @@ package drivers import ( "errors" - "fmt" "testing" "github.com/stretchr/testify/assert" @@ -18,7 +17,7 @@ func TestIP(t *testing.T) { {&BaseDriver{IPAddress: "2001:4860:0:2001::68"}, "2001:4860:0:2001::68", nil}, {&BaseDriver{IPAddress: "192.168.0.1"}, "192.168.0.1", nil}, {&BaseDriver{IPAddress: "::1"}, "::1", nil}, - {&BaseDriver{IPAddress: "whatever"}, "", fmt.Errorf("IP address is invalid: %s", "whatever")}, + {&BaseDriver{IPAddress: "hostname"}, "hostname", nil}, } for _, c := range cases {