From a150a0d521cf65127d247f9c5dfa9b7ed30885a3 Mon Sep 17 00:00:00 2001 From: Dong Chen Date: Thu, 5 Nov 2015 17:14:50 -0800 Subject: [PATCH] Add cli test for engine refresh options Signed-off-by: Dong Chen --- cluster/engine.go | 3 --- test/integration/engine_options.bats | 20 ++++++++++++++++++++ 2 files changed, 20 insertions(+), 3 deletions(-) create mode 100644 test/integration/engine_options.bats diff --git a/cluster/engine.go b/cluster/engine.go index 705fb429c5..8c58b779cc 100644 --- a/cluster/engine.go +++ b/cluster/engine.go @@ -89,9 +89,6 @@ type Engine struct { // NewEngine is exported func NewEngine(addr string, overcommitRatio float64, opts *EngineOpts) *Engine { - if opts == nil { - log.Fatal("EngineOpts is nil") - } e := &Engine{ Addr: addr, client: nopclient.NewNopClient(), diff --git a/test/integration/engine_options.bats b/test/integration/engine_options.bats new file mode 100644 index 0000000000..c2347489ab --- /dev/null +++ b/test/integration/engine_options.bats @@ -0,0 +1,20 @@ +#!/usr/bin/env bats + +load helpers + +@test "engine refresh options" { + # minimum refresh interval + run swarm manage --engine-refresh-min-interval "0s" --advertise 127.0.0.1:$SWARM_BASE_PORT 192.168.56.202:4444 + [ "$status" -ne 0 ] + [[ "${output}" == *"minimum refresh interval should be a positive number"* ]] + + # max refresh interval + run swarm manage --engine-refresh-min-interval "30s" -engine-refresh-max-interval "20s" --advertise 127.0.0.1:$SWARM_BASE_PORT 192.168.56.202:4444 + [ "$status" -ne 0 ] + [[ "${output}" == *"max refresh interval cannot be less than min refresh interval"* ]] + + # engine refresh retry count + run swarm manage --engine-refresh-retry 0 --advertise 127.0.0.1:$SWARM_BASE_PORT 192.168.56.202:4444 + [ "$status" -ne 0 ] + [[ "${output}" == *"invalid refresh retry count"* ]] +}