diff --git a/Makefile b/Makefile index 2910f61ba1..1f45ed5dd2 100644 --- a/Makefile +++ b/Makefile @@ -118,13 +118,13 @@ protos: # be run first define gocover -$(GO_EXC) test $(OPTS) $(TESTOPTS) -covermode="$(COVERMODE)" -coverprofile="$(COVERDIR)/$(subst /,-,$(1)).$(subst $(_space),.,$(NOTARY_BUILDTAGS)).cover" "$(1)" || exit 1; +$(GO_EXC) test $(OPTS) $(TESTOPTS) -covermode="$(COVERMODE)" -coverprofile="$(COVERDIR)/$(subst /,-,$(1)).$(subst $(_space),.,$(NOTARY_BUILDTAGS)).coverage.txt" "$(1)" || exit 1; endef gen-cover: go_version @mkdir -p "$(COVERDIR)" $(foreach PKG,$(PKGS),$(call gocover,$(PKG))) - rm "$(COVERDIR)"/*testutils*.cover + rm "$(COVERDIR)"/*testutils*.coverage.txt # Generates the cover binaries and runs them all in serial, so this can be used # run all tests with a yubikey without any problems diff --git a/circle.yml b/circle.yml index 10a28305d3..99a3639056 100644 --- a/circle.yml +++ b/circle.yml @@ -18,6 +18,8 @@ machine: CIRCLE_PAIN: "mode: set" # Put the coverage profile somewhere codecov's script can find it COVERPROFILE: coverage.out + # Set the pull request number so codecov can figure it out + PULL_REQUEST: ${CI_PULL_REQUEST##*/} hosts: # Not used yet @@ -40,8 +42,7 @@ dependencies: # For the stable go version, additionally install linting tools - > gvm use stable && - go get github.com/golang/lint/golint github.com/wadey/gocovmerge && - go install github.com/wadey/gocovmerge + go get github.com/golang/lint/golint test: pre: # Output the go versions we are going to test @@ -72,11 +73,6 @@ test: pwd: $BASE_STABLE post: - - gvm use stable && make covmerge: - timeout: 600 - parallel: true - pwd: $BASE_STABLE - # Report to codecov.io - bash <(curl -s https://codecov.io/bash): parallel: true