From a6a5cb5ebef45e20ba8f09a67d51d43675ddebc6 Mon Sep 17 00:00:00 2001
From: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Date: Thu, 25 Jan 2024 08:31:57 +0100
Subject: [PATCH] js: remove sidebar scrolldown effect

When accessing a page that's far down the left-hand sidebar, we have a
script that would scroll the sidebar position down so that the selected
item is visible. In some cases, this would cause some confusion and
jittery rendering on page load.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
---
 assets/js/src/sidebar.js | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/assets/js/src/sidebar.js b/assets/js/src/sidebar.js
index ab34d7d004..eb3c148de5 100644
--- a/assets/js/src/sidebar.js
+++ b/assets/js/src/sidebar.js
@@ -1,18 +1,3 @@
-// Scroll the given menu item into view. We actually pick the item *above*
-// the current item to give some headroom above
-function scrollMenuItem() {
-  let item = sectiontree.querySelector('[aria-current="page"]');
-  if (!item) return;
-  item = item.parentElement.closest("li");
-  if (item) {
-    const itemY = item.getBoundingClientRect().y;
-    // scroll to the item y-coord (with a 150px padding for some head room)
-    if (itemY > window.innerHeight - 150) {
-      sidebar.scrollTop = itemY - 150;
-    }
-  }
-}
-
 function toggleMenuItem(event) {
   const section = event.currentTarget.parentElement;
   const icon = section.querySelector(".icon");
@@ -26,9 +11,7 @@ function toggleMenuItem(event) {
 }
 
 const sectiontree = document.querySelector("#sectiontree");
-const sidebar = document.querySelector("#sidebar");
-if (sectiontree && sidebar) {
-  scrollMenuItem();
+if (sectiontree) {
   for (const button of sectiontree.querySelectorAll("button")) {
     button.addEventListener("click", toggleMenuItem);
   }