docker
/
docs
mirror of https://github.com/docker/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #258 from mtrmac/unused-sha256 

Don't compute an unnecessary cryptographic hash
This commit is contained in:
David Lawrence 2015-11-02 11:12:39 -08:00
parent dfaa8daf9b 29ae808472
commit ab6637934d
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tuf/client/client.go
View File

@ -405,9 +405,11 @@ func (c *Client) downloadSigned(role string, size int64, expectedSha256 []byte)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
} }
genHash := sha256.Sum256(raw) if expectedSha256 != nil {
if expectedSha256 != nil && !bytes.Equal(genHash[:], expectedSha256) { genHash := sha256.Sum256(raw)
return nil, nil, ErrChecksumMismatch{role: role} if !bytes.Equal(genHash[:], expectedSha256) {
return nil, nil, ErrChecksumMismatch{role: role}
}
} }
s := &data.Signed{} s := &data.Signed{}
err = json.Unmarshal(raw, s) err = json.Unmarshal(raw, s)