From adcb1edfa7b70db26f42d6977a52101ddf948e6b Mon Sep 17 00:00:00 2001
From: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Date: Fri, 23 Feb 2024 15:01:55 +0100
Subject: [PATCH] chore: style and script refactor

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
---
 assets/css/global.css                          |  6 ------
 assets/css/icons.css                           | 18 ++++++++++++++++++
 .../js/src/{tooltip.js => dockerfile-links.js} |  0
 layouts/_default/_markup/render-link.html      |  4 ++--
 layouts/partials/github-links.html             |  8 ++++----
 5 files changed, 24 insertions(+), 12 deletions(-)
 rename assets/js/src/{tooltip.js => dockerfile-links.js} (100%)

diff --git a/assets/css/global.css b/assets/css/global.css
index 18b44137cc..0b8471c001 100644
--- a/assets/css/global.css
+++ b/assets/css/global.css
@@ -18,12 +18,6 @@
     @apply text-blue-light underline underline-offset-2 dark:text-blue-dark;
   }
 
-  .external-link {
-    .icon-svg svg {
-      @apply text-base ml-1 align-top;
-    }
-  }
-
   .invertible {
     @apply dark:hue-rotate-180 dark:invert dark:filter;
   }
diff --git a/assets/css/icons.css b/assets/css/icons.css
index d68025ee32..4a6121f460 100644
--- a/assets/css/icons.css
+++ b/assets/css/icons.css
@@ -8,4 +8,22 @@
       fill: currentColor;
     }
   }
+
+  .icon-xs {
+    svg {
+      @apply text-base;
+    }
+  }
+
+  .icon-sm {
+    svg {
+      @apply text-lg;
+    }
+  }
+
+  .icon-top {
+    svg {
+      @apply ml-1 align-top;
+    }
+  }
 }
diff --git a/assets/js/src/tooltip.js b/assets/js/src/dockerfile-links.js
similarity index 100%
rename from assets/js/src/tooltip.js
rename to assets/js/src/dockerfile-links.js
diff --git a/layouts/_default/_markup/render-link.html b/layouts/_default/_markup/render-link.html
index 9497c6f2d3..d0fb36db14 100644
--- a/layouts/_default/_markup/render-link.html
+++ b/layouts/_default/_markup/render-link.html
@@ -2,12 +2,12 @@
 {{- if (strings.HasPrefix $url "http") -}}
   {{/* external link, add icon */}}
   <a
-    class="link external-link"
+    class="link"
     href="{{ $url | safeURL }}"
     target="_blank"
     rel="noopener">
       {{- .Text | safeHTML -}}
-      <span class="icon-svg">
+      <span class="icon-svg icon-xs icon-top">
         {{- partial "icon" "open_in_new" -}}
       </span></a>
 {{- else if (strings.HasPrefix $url "/") -}}
diff --git a/layouts/partials/github-links.html b/layouts/partials/github-links.html
index d2e8a7e5d0..7755e4952b 100644
--- a/layouts/partials/github-links.html
+++ b/layouts/partials/github-links.html
@@ -3,9 +3,9 @@
 {{ if not (in .Filename "/_vendor/") }}
 <p class="flex items-center gap-2">
   <span class="icon-svg">{{ partial "icon" "edit" }}</span>
-  <a class="link external-link" target="_blank" rel="noopener"
+  <a class="link" target="_blank" rel="noopener"
     href="{{ site.Params.repo }}/edit/main/content/{{ .Path }}">{{ T "editPage" }}
-    <span class="icon-svg">
+    <span class="icon-svg icon-xs icon-top">
       {{- partial "icon" "open_in_new" -}}
     </span></a>
 </p>
@@ -13,9 +13,9 @@
 {{ end }}
 <p class="flex items-center gap-2">
   <span class="icon-svg">{{ partial "icon" "done" }}</span>
-  <a class="link external-link" target="_blank" rel="noopener"
+  <a class="link" target="_blank" rel="noopener"
     href="{{ site.Params.repo }}/issues/new?template=doc_issue.yml&location={{ .Permalink }}&labels=status%2Ftriage">{{ T "requestChanges" }}
-    <span class="icon-svg">
+    <span class="icon-svg icon-xs icon-top">
       {{- partial "icon" "open_in_new" -}}
     </span></a>
   </a>