docker
/
docs
mirror of https://github.com/docker/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bug where too many '/tcp' suffixes were added to port config

This commit is contained in:
Aanand Prasad 2014-01-22 16:52:42 +00:00
parent 18525554ed
commit ae67d55bf2
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fig/service.py
View File

@ -225,8 +225,6 @@ class Service(object):
port = str(port) port = str(port)
if ':' in port: if ':' in port:
port = port.split(':')[-1] port = port.split(':')[-1]
if '/' not in port:
port = "%s/tcp" % port
ports.append(port) ports.append(port)
container_options['ports'] = ports container_options['ports'] = ports

2
tests/service_test.py
View File

@ -184,7 +184,7 @@ class ServiceTest(DockerClientTestCase):
def test_start_container_creates_ports(self): def test_start_container_creates_ports(self):
service = self.create_service('web', ports=[8000]) service = self.create_service('web', ports=[8000])
container = service.start_container().inspect() container = service.start_container().inspect()
self.assertIn('8000/tcp', container['HostConfig']['PortBindings']) self.assertEqual(container['HostConfig']['PortBindings'].keys(), ['8000/tcp'])
self.assertNotEqual(container['HostConfig']['PortBindings']['8000/tcp'][0]['HostPort'], '8000') self.assertNotEqual(container['HostConfig']['PortBindings']['8000/tcp'][0]['HostPort'], '8000')
def test_start_container_creates_fixed_external_ports(self): def test_start_container_creates_fixed_external_ports(self):