docker
/
docs
mirror of https://github.com/docker/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7304 from unclejack/refactor_build_tests 

integration cli: minor refactor of the build tests
This commit is contained in:
unclejack 2014-08-08 01:24:51 +03:00
parent 01022a305d 372f9bb58b
commit b36f630817
2 changed files with 91 additions and 110 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

187
integration-cli/docker_cli_build_test.go
View File

@ -15,24 +15,28 @@ import (
) )
func TestBuildCacheADD(t *testing.T) { func TestBuildCacheADD(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildCacheADD", "1") var (
buildCmd := exec.Command(dockerBinary, "build", "-t", "testcacheadd1", ".") exitCode int
buildCmd.Dir = buildDirectory out string
exitCode, err := runCommand(buildCmd) err error
errorOut(err, t, fmt.Sprintf("build failed to complete: %v", err)) )
{
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildCacheADD", "1")
out, exitCode, err = dockerCmdInDir(t, buildDirectory, "build", "-t", "testcacheadd1", ".")
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
t.Fatal("failed to build the image") t.Fatal("failed to build the image")
}
} }
{
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildCacheADD", "2")
out, exitCode, err = dockerCmdInDir(t, buildDirectory, "build", "-t", "testcacheadd2", ".")
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
buildDirectory = filepath.Join(workingDirectory, "build_tests", "TestBuildCacheADD", "2") if err != nil || exitCode != 0 {
buildCmd = exec.Command(dockerBinary, "build", "-t", "testcacheadd2", ".") t.Fatal("failed to build the image")
buildCmd.Dir = buildDirectory }
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 {
t.Fatal("failed to build the image")
} }
if strings.Contains(out, "Using cache") { if strings.Contains(out, "Using cache") {
@ -47,9 +51,7 @@ func TestBuildCacheADD(t *testing.T) {
func TestBuildSixtySteps(t *testing.T) { func TestBuildSixtySteps(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildSixtySteps") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildSixtySteps")
buildCmd := exec.Command(dockerBinary, "build", "-t", "foobuildsixtysteps", ".") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "foobuildsixtysteps", ".")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -68,9 +70,7 @@ func TestAddSingleFileToRoot(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
f.Close() f.Close()
buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", ".") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", ".")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -120,9 +120,7 @@ func TestAddSingleFileToWorkdir(t *testing.T) {
func TestAddSingleFileToExistDir(t *testing.T) { func TestAddSingleFileToExistDir(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", "SingleFileToExistDir") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "SingleFileToExistDir")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -136,9 +134,7 @@ func TestAddSingleFileToExistDir(t *testing.T) {
func TestAddSingleFileToNonExistDir(t *testing.T) { func TestAddSingleFileToNonExistDir(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", "SingleFileToNonExistDir") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "SingleFileToNonExistDir")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -152,9 +148,7 @@ func TestAddSingleFileToNonExistDir(t *testing.T) {
func TestAddDirContentToRoot(t *testing.T) { func TestAddDirContentToRoot(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", "DirContentToRoot") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "DirContentToRoot")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -168,9 +162,7 @@ func TestAddDirContentToRoot(t *testing.T) {
func TestAddDirContentToExistDir(t *testing.T) { func TestAddDirContentToExistDir(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", "DirContentToExistDir") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "DirContentToExistDir")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -193,9 +185,7 @@ func TestAddWholeDirToRoot(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
f.Close() f.Close()
buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", ".") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", ".")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -209,9 +199,7 @@ func TestAddWholeDirToRoot(t *testing.T) {
func TestAddEtcToRoot(t *testing.T) { func TestAddEtcToRoot(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestAdd")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testaddimg", "EtcToRoot") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testaddimg", "EtcToRoot")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -229,9 +217,7 @@ func TestCopySingleFileToRoot(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
f.Close() f.Close()
buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", ".") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -281,9 +267,7 @@ func TestCopySingleFileToWorkdir(t *testing.T) {
func TestCopySingleFileToExistDir(t *testing.T) { func TestCopySingleFileToExistDir(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "SingleFileToExistDir") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToExistDir")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -297,9 +281,7 @@ func TestCopySingleFileToExistDir(t *testing.T) {
func TestCopySingleFileToNonExistDir(t *testing.T) { func TestCopySingleFileToNonExistDir(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "SingleFileToNonExistDir") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "SingleFileToNonExistDir")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -313,9 +295,7 @@ func TestCopySingleFileToNonExistDir(t *testing.T) {
func TestCopyDirContentToRoot(t *testing.T) { func TestCopyDirContentToRoot(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "DirContentToRoot") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToRoot")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -329,9 +309,7 @@ func TestCopyDirContentToRoot(t *testing.T) {
func TestCopyDirContentToExistDir(t *testing.T) { func TestCopyDirContentToExistDir(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "DirContentToExistDir") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "DirContentToExistDir")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -354,9 +332,7 @@ func TestCopyWholeDirToRoot(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
f.Close() f.Close()
buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", ".") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", ".")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -370,9 +346,7 @@ func TestCopyWholeDirToRoot(t *testing.T) {
func TestCopyEtcToRoot(t *testing.T) { func TestCopyEtcToRoot(t *testing.T) {
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestCopy")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testcopyimg", "EtcToRoot") out, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testcopyimg", "EtcToRoot")
buildCmd.Dir = buildDirectory
out, exitCode, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err)) errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out, err))
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
@ -465,9 +439,7 @@ func TestBuildWithInaccessibleFilesInContext(t *testing.T) {
// This test doesn't require that we run commands as an unprivileged user // This test doesn't require that we run commands as an unprivileged user
pathToDirectoryWhichContainsLinks := filepath.Join(buildDirectory, "linksdirectory") pathToDirectoryWhichContainsLinks := filepath.Join(buildDirectory, "linksdirectory")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testlinksok", ".") out, exitCode, err := dockerCmdInDir(t, pathToDirectoryWhichContainsLinks, "build", "-t", "testlinksok", ".")
buildCmd.Dir = pathToDirectoryWhichContainsLinks
out, exitCode, err := runCommandWithOutput(buildCmd)
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
t.Fatalf("build should have worked: %s %s", err, out) t.Fatalf("build should have worked: %s %s", err, out)
} }
@ -538,9 +510,7 @@ func TestBuildRm(t *testing.T) {
} }
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
buildCmd := exec.Command(dockerBinary, "build", "--rm", "-t", "testbuildrm", ".") _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "--rm", "-t", "testbuildrm", ".")
buildCmd.Dir = buildDirectory
_, exitCode, err := runCommandWithOutput(buildCmd)
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
t.Fatal("failed to build the image") t.Fatal("failed to build the image")
@ -564,9 +534,7 @@ func TestBuildRm(t *testing.T) {
} }
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
buildCmd := exec.Command(dockerBinary, "build", "-t", "testbuildrm", ".") _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "-t", "testbuildrm", ".")
buildCmd.Dir = buildDirectory
_, exitCode, err := runCommandWithOutput(buildCmd)
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
t.Fatal("failed to build the image") t.Fatal("failed to build the image")
@ -590,9 +558,7 @@ func TestBuildRm(t *testing.T) {
} }
buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm") buildDirectory := filepath.Join(workingDirectory, "build_tests", "TestBuildRm")
buildCmd := exec.Command(dockerBinary, "build", "--rm=false", "-t", "testbuildrm", ".") _, exitCode, err := dockerCmdInDir(t, buildDirectory, "build", "--rm=false", "-t", "testbuildrm", ".")
buildCmd.Dir = buildDirectory
_, exitCode, err := runCommandWithOutput(buildCmd)
if err != nil || exitCode != 0 { if err != nil || exitCode != 0 {
t.Fatal("failed to build the image") t.Fatal("failed to build the image")
@ -808,52 +774,53 @@ func TestBuildEntrypoint(t *testing.T) {
// #6445 ensure ONBUILD triggers aren't committed to grandchildren // #6445 ensure ONBUILD triggers aren't committed to grandchildren
func TestBuildOnBuildLimitedInheritence(t *testing.T) { func TestBuildOnBuildLimitedInheritence(t *testing.T) {
name1 := "testonbuildtrigger1" var (
dockerfile1 := ` out2, out3 string
)
{
name1 := "testonbuildtrigger1"
dockerfile1 := `
FROM busybox FROM busybox
RUN echo "GRANDPARENT" RUN echo "GRANDPARENT"
ONBUILD RUN echo "ONBUILD PARENT" ONBUILD RUN echo "ONBUILD PARENT"
` `
ctx1, err := fakeContext(dockerfile1, nil) ctx, err := fakeContext(dockerfile1, nil)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
}
out1, _, err := dockerCmdInDir(t, ctx.Dir, "build", "-t", name1, ".")
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out1, err))
defer deleteImages(name1)
} }
{
buildCmd := exec.Command(dockerBinary, "build", "-t", name1, ".") name2 := "testonbuildtrigger2"
buildCmd.Dir = ctx1.Dir dockerfile2 := `
out1, _, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out1, err))
defer deleteImages(name1)
name2 := "testonbuildtrigger2"
dockerfile2 := `
FROM testonbuildtrigger1 FROM testonbuildtrigger1
` `
ctx2, err := fakeContext(dockerfile2, nil) ctx, err := fakeContext(dockerfile2, nil)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
}
out2, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name2, ".")
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out2, err))
defer deleteImages(name2)
} }
{
buildCmd = exec.Command(dockerBinary, "build", "-t", name2, ".") name3 := "testonbuildtrigger3"
buildCmd.Dir = ctx2.Dir dockerfile3 := `
out2, _, err := runCommandWithOutput(buildCmd)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out2, err))
defer deleteImages(name2)
name3 := "testonbuildtrigger3"
dockerfile3 := `
FROM testonbuildtrigger2 FROM testonbuildtrigger2
` `
ctx3, err := fakeContext(dockerfile3, nil) ctx, err := fakeContext(dockerfile3, nil)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
buildCmd = exec.Command(dockerBinary, "build", "-t", name3, ".") out3, _, err = dockerCmdInDir(t, ctx.Dir, "build", "-t", name3, ".")
buildCmd.Dir = ctx3.Dir errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out3, err))
out3, _, err := runCommandWithOutput(buildCmd) defer deleteImages(name3)
errorOut(err, t, fmt.Sprintf("build failed to complete: %v %v", out3, err)) }
defer deleteImages(name3)
// ONBUILD should be run in second build. // ONBUILD should be run in second build.
if !strings.Contains(out2, "ONBUILD PARENT") { if !strings.Contains(out2, "ONBUILD PARENT") {

14
integration-cli/docker_utils.go
View File

@ -88,12 +88,26 @@ func pullImageIfNotExist(image string) (err error) {
return return
} }
// deprecated, use dockerCmd instead
func cmd(t *testing.T, args ...string) (string, int, error) { func cmd(t *testing.T, args ...string) (string, int, error) {
return dockerCmd(t, args...)
}
func dockerCmd(t *testing.T, args ...string) (string, int, error) {
out, status, err := runCommandWithOutput(exec.Command(dockerBinary, args...)) out, status, err := runCommandWithOutput(exec.Command(dockerBinary, args...))
errorOut(err, t, fmt.Sprintf("'%s' failed with errors: %v (%v)", strings.Join(args, " "), err, out)) errorOut(err, t, fmt.Sprintf("'%s' failed with errors: %v (%v)", strings.Join(args, " "), err, out))
return out, status, err return out, status, err
} }
// execute a docker command in a directory
func dockerCmdInDir(t *testing.T, path string, args ...string) (string, int, error) {
dockerCommand := exec.Command(dockerBinary, args...)
dockerCommand.Dir = path
out, status, err := runCommandWithOutput(dockerCommand)
errorOut(err, t, fmt.Sprintf("'%s' failed with errors: %v (%v)", strings.Join(args, " "), err, out))
return out, status, err
}
func findContainerIp(t *testing.T, id string) string { func findContainerIp(t *testing.T, id string) string {
cmd := exec.Command(dockerBinary, "inspect", "--format='{{ .NetworkSettings.IPAddress }}'", id) cmd := exec.Command(dockerBinary, "inspect", "--format='{{ .NetworkSettings.IPAddress }}'", id)
out, _, err := runCommandWithOutput(cmd) out, _, err := runCommandWithOutput(cmd)