Merge pull request #10914 from kargakis/map-commands

Map Commands instead of using them as a slice

builder/command/command.go

@@ -19,19 +19,19 @@ const (
 )
 
 // Commands is list of all Dockerfile commands
-var Commands = []string{
+var Commands = map[string]struct{}{
-	Env,
+	Env:        {},
-	Maintainer,
+	Maintainer: {},
-	Add,
+	Add:        {},
-	Copy,
+	Copy:       {},
-	From,
+	From:       {},
-	Onbuild,
+	Onbuild:    {},
-	Workdir,
+	Workdir:    {},
-	Run,
+	Run:        {},
-	Cmd,
+	Cmd:        {},
-	Entrypoint,
+	Entrypoint: {},
-	Expose,
+	Expose:     {},
-	Volume,
+	Volume:     {},
-	User,
+	User:       {},
-	Insert,
+	Insert:     {},
 }

integration-cli/docker_cli_build_test.go

@@ -4836,7 +4836,7 @@ func TestBuildMissingArgs(t *testing.T) {
 
 	defer deleteAllContainers()
 
-	for _, cmd := range command.Commands {
+	for cmd := range command.Commands {
 		cmd = strings.ToUpper(cmd)
 		if _, ok := skipCmds[cmd]; ok {
 			continue