From cbfdca180817448d4306dbf18596360c84578eec Mon Sep 17 00:00:00 2001 From: Sven Dowideit Date: Thu, 20 Aug 2015 13:50:39 +1000 Subject: [PATCH] DTR-939: all DELETE verbs report 204-success based on final state, not on verb action Signed-off-by: Sven Dowideit --- api/dtr_1_3_accounts.md | 2 +- api/dtr_1_3_repositories.md | 2 +- api/dtr_1_3_team_repo_access.md | 3 +-- api/dtr_1_3_team_repo_namespace_access.md | 3 +-- api/dtr_1_3_teams.md | 4 ++-- api/dtr_1_3_user_repo_access.md | 2 +- 6 files changed, 7 insertions(+), 9 deletions(-) diff --git a/api/dtr_1_3_accounts.md b/api/dtr_1_3_accounts.md index 82d7df32e4..3dfb755a32 100755 --- a/api/dtr_1_3_accounts.md +++ b/api/dtr_1_3_accounts.md @@ -294,7 +294,7 @@ Client must be authenticated as a system 'admin' user. - *401* client must be authenticated. - *403* client must be an admin. -- *204* (`No Content`) success. +- *204* (`No Content`) success - or account does not exist. ## Change a Managed User's Password diff --git a/api/dtr_1_3_repositories.md b/api/dtr_1_3_repositories.md index 5ec6996786..ced21c2f19 100755 --- a/api/dtr_1_3_repositories.md +++ b/api/dtr_1_3_repositories.md @@ -203,4 +203,4 @@ level access to the organization's repository). **Status Codes** - *403* the client is not authorized. -- *204* success. +- *204* (`No Content`) success - or repository does not exist. diff --git a/api/dtr_1_3_team_repo_access.md b/api/dtr_1_3_team_repo_access.md index 5f505149a5..2a06728553 100755 --- a/api/dtr_1_3_team_repo_access.md +++ b/api/dtr_1_3_team_repo_access.md @@ -219,6 +219,5 @@ repository. - *404* the repository is not visible to the client. - *400* the repository is not owned by an organiztion. -- *400* the team does not belong to the owning organization. - *403* the client is not authorized. -- *200* success. +- *204* (`No Content`) success - or team is not in the access list or there is no such team in the organization. diff --git a/api/dtr_1_3_team_repo_namespace_access.md b/api/dtr_1_3_team_repo_namespace_access.md index 5b3c5d43ae..b2298e6370 100755 --- a/api/dtr_1_3_team_repo_namespace_access.md +++ b/api/dtr_1_3_team_repo_namespace_access.md @@ -197,6 +197,5 @@ namespace. **Status Codes** - *400* the repository is not owned by an organization. -- *400* the team does not belong to the owning organization. - *403* the client is not authorized. -- *200* success. +- *204* (`No Content`) success - or team does not exist in the access list or there is no such team in the organization. diff --git a/api/dtr_1_3_teams.md b/api/dtr_1_3_teams.md index 3492f6bd83..61496ff3b8 100755 --- a/api/dtr_1_3_teams.md +++ b/api/dtr_1_3_teams.md @@ -284,7 +284,7 @@ team in the organization. - *403* the client is not authorized. - *404* no such team exists. -- *204* success. +- *204* (`No Content`) success - or user is not in the team. ## Remove a Team. @@ -302,4 +302,4 @@ team in the organization. **Status Codes** - *403* the client is not authorized. -- *204* success. +- *204* (`No Content`) success - or team does not exist. diff --git a/api/dtr_1_3_user_repo_access.md b/api/dtr_1_3_user_repo_access.md index e108b3c03c..5c3d967a41 100755 --- a/api/dtr_1_3_user_repo_access.md +++ b/api/dtr_1_3_user_repo_access.md @@ -155,4 +155,4 @@ repository. - *404* the repository is not visible to the client. - *400* the repository is not owned by a user. - *403* the client is not authorized. -- *204* (no content) success. +- *204* (`No Content`) success - or user is not in the access list.