From d420134fa2ea8ceedf2a9a64263d09b308263c2c Mon Sep 17 00:00:00 2001 From: Mike Snitzer Date: Fri, 20 Jun 2014 11:45:42 -0400 Subject: [PATCH] devmapper: fix reloadPool() to also specify '1 skip_block_zeroing' createPool() and reloadPool() should be consistent with the thin-pool table params they use. Since createPool() specifies '1 skip_block_zeroing' reloadPool() should too. Otherwise, if the pool is reloaded (as is done when resizing loopback devices) block zeroing will be enabled after the reload completes. Docker-DCO-1.1-Signed-off-by: Mike Snitzer (github: snitm) --- daemon/graphdriver/devmapper/devmapper.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/graphdriver/devmapper/devmapper.go b/daemon/graphdriver/devmapper/devmapper.go index a6602c276e..2590ec0fc1 100644 --- a/daemon/graphdriver/devmapper/devmapper.go +++ b/daemon/graphdriver/devmapper/devmapper.go @@ -369,7 +369,7 @@ func reloadPool(poolName string, dataFile, metadataFile *os.File) error { return fmt.Errorf("Can't get data size %s", err) } - params := metadataFile.Name() + " " + dataFile.Name() + " 128 32768" + params := metadataFile.Name() + " " + dataFile.Name() + " 128 32768 1 skip_block_zeroing" if err := task.AddTarget(0, size/512, "thin-pool", params); err != nil { return fmt.Errorf("Can't add target %s", err) }