From d7241f3682a212a25f6425af88350b8ba017438e Mon Sep 17 00:00:00 2001
From: allencloud <allen.sun@daocloud.io>
Date: Sun, 22 May 2016 19:46:59 +0800
Subject: [PATCH] remove engine details in POST /volumes/create API

Signed-off-by: allencloud <allen.sun@daocloud.io>
---
 cluster/cluster.go       | 2 +-
 cluster/engine.go        | 9 ++++-----
 cluster/mesos/cluster.go | 2 +-
 cluster/swarm/cluster.go | 4 ++--
 4 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/cluster/cluster.go b/cluster/cluster.go
index 19ee1f89ea..c50dcad660 100644
--- a/cluster/cluster.go
+++ b/cluster/cluster.go
@@ -45,7 +45,7 @@ type Cluster interface {
 	RemoveNetwork(network *Network) error
 
 	// Create a volume
-	CreateVolume(request *types.VolumeCreateRequest) (*Volume, error)
+	CreateVolume(request *types.VolumeCreateRequest) (*types.Volume, error)
 
 	// Return all volumes
 	Volumes() Volumes
diff --git a/cluster/engine.go b/cluster/engine.go
index 86d5ffad0c..5a3cc80ea5 100644
--- a/cluster/engine.go
+++ b/cluster/engine.go
@@ -945,17 +945,16 @@ func (e *Engine) CreateNetwork(name string, request *types.NetworkCreate) (*type
 }
 
 // CreateVolume creates a volume in the engine
-func (e *Engine) CreateVolume(request *types.VolumeCreateRequest) (*Volume, error) {
+func (e *Engine) CreateVolume(request *types.VolumeCreateRequest) (*types.Volume, error) {
 	volume, err := e.apiClient.VolumeCreate(context.Background(), *request)
-
-	e.RefreshVolumes()
 	e.CheckConnectionErr(err)
-
 	if err != nil {
 		return nil, err
 	}
-	return &Volume{Volume: volume, Engine: e}, nil
 
+	e.RefreshVolumes()
+
+	return &volume, err
 }
 
 // encodeAuthToBase64 serializes the auth configuration as JSON base64 payload
diff --git a/cluster/mesos/cluster.go b/cluster/mesos/cluster.go
index 948b964e84..4c01caf737 100644
--- a/cluster/mesos/cluster.go
+++ b/cluster/mesos/cluster.go
@@ -301,7 +301,7 @@ func (c *Cluster) refreshNetworks() {
 }
 
 // CreateVolume creates a volume in the cluster
-func (c *Cluster) CreateVolume(request *types.VolumeCreateRequest) (*cluster.Volume, error) {
+func (c *Cluster) CreateVolume(request *types.VolumeCreateRequest) (*types.Volume, error) {
 	return nil, errNotSupported
 }
 
diff --git a/cluster/swarm/cluster.go b/cluster/swarm/cluster.go
index d0634b0af8..7fa3b973d2 100644
--- a/cluster/swarm/cluster.go
+++ b/cluster/swarm/cluster.go
@@ -493,10 +493,10 @@ func (c *Cluster) CreateNetwork(name string, request *types.NetworkCreate) (resp
 }
 
 // CreateVolume creates a volume in the cluster
-func (c *Cluster) CreateVolume(request *types.VolumeCreateRequest) (*cluster.Volume, error) {
+func (c *Cluster) CreateVolume(request *types.VolumeCreateRequest) (*types.Volume, error) {
 	var (
 		wg     sync.WaitGroup
-		volume *cluster.Volume
+		volume *types.Volume
 		err    error
 		parts  = strings.SplitN(request.Name, "/", 2)
 		node   = ""