From dbe1f46d4b7d7199c2e8d537750ea704ea65fcb3 Mon Sep 17 00:00:00 2001 From: Jeffrey Morgan Date: Sun, 18 Oct 2015 15:57:03 -0700 Subject: [PATCH] Fixed bug where user could not delete a container that failed to start --- src/utils/DockerUtil.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/utils/DockerUtil.js b/src/utils/DockerUtil.js index 177faef2ee..0b7d0ec26b 100644 --- a/src/utils/DockerUtil.js +++ b/src/utils/DockerUtil.js @@ -101,7 +101,6 @@ export default { containerData.Env = containerData.Config.Env; } - containerData.Volumes = _.mapObject(containerData.Volumes, () => {return {};}); let existing = this.client.getContainer(name); @@ -114,6 +113,8 @@ export default { } metrics.track('Container Finished Creating'); this.startContainer(name, containerData); + delete this.placeholders[name]; + localStorage.setItem('placeholders', JSON.stringify(this.placeholders)); }); }); }); @@ -164,7 +165,7 @@ export default { Name: name, Image: imageName, Config: { - Image: imageName, + Image: imageName }, Tty: true, OpenStdin: true, @@ -187,8 +188,6 @@ export default { return; } - delete this.placeholders[name]; - localStorage.setItem('placeholders', JSON.stringify(this.placeholders)); this.createContainer(name, {Image: imageName, Tty: true, OpenStdin: true}); },