Merge pull request #1109 from ibuildthecloud/no-default-storage-driver

Default storage driver to "" and let provisioner choose default
This commit is contained in:
Evan Hazlett 2015-05-05 10:46:47 -07:00
commit fdc8538de4
4 changed files with 14 additions and 1 deletions

View File

@ -188,7 +188,6 @@ var sharedCreateFlags = []cli.Flag{
cli.StringFlag{
Name: "engine-storage-driver",
Usage: "Specify a storage driver to use with the engine",
Value: "aufs",
},
cli.BoolFlag{
Name: "swarm",

View File

@ -191,6 +191,10 @@ func (provisioner *Boot2DockerProvisioner) Provision(swarmOptions swarm.SwarmOpt
provisioner.AuthOptions = authOptions
provisioner.EngineOptions = engineOptions
if provisioner.EngineOptions.StorageDriver == "" {
provisioner.EngineOptions.StorageDriver = "aufs"
}
if err := provisioner.SetHostname(provisioner.Driver.GetMachineName()); err != nil {
return err
}

View File

@ -87,6 +87,11 @@ func (provisioner *UbuntuProvisioner) Provision(swarmOptions swarm.SwarmOptions,
provisioner.SwarmOptions = swarmOptions
provisioner.AuthOptions = authOptions
provisioner.EngineOptions = engineOptions
if provisioner.EngineOptions.StorageDriver == "" {
provisioner.EngineOptions.StorageDriver = "aufs"
}
if err := provisioner.SetHostname(provisioner.Driver.GetMachineName()); err != nil {
return err
}

View File

@ -302,6 +302,11 @@ buildMachineWithOldIsoCheckUpgrade() {
[ "$status" -eq 0 ]
}
@test "$DRIVER: create with no storage driver" {
run machine create -d $DRIVER --engine-storage-driver "" $NAME
[ "$status" -eq 0 ]
}
@test "$DRIVER: create with custom disk, cpu count and memory size flags" {
run machine create -d $DRIVER --virtualbox-cpu-count $CUSTOM_CPUCOUNT --virtualbox-disk-size $CUSTOM_DISKSIZE --virtualbox-memory $CUSTOM_MEMSIZE $NAME
[ "$status" -eq 0 ]