Commit Graph

22 Commits

Author SHA1 Message Date
Rob Jackson 6e0df9e39e Ensure custom build hooks consume DOCKERFILE_PATH (#6026)
I have a custom build hook to pass in build arguments on a repository from which I build two Docker images (tags), from two Dockerfiles.

My second build, however, with the custom Dockerfile, was not being built correctly. It was being built with the default `Dockerfile`, instead of my specified custom one.

I quickly figured out the custom build hook was to blame because it doesn't specify which Dockerfile it should build from, but there was no mention in the documentation of an environmental variable I can consume to get the custom "Dockerfile location" value. By dumping the env vars during the build process, I can there is an environmental variable with that value: `DOCKERFILE_PATH`.

This PR updates the documentation accordingly, to:

1) Expose the fact this environmental variable exists, and explains its purpose
2) Make sure its consumed in the example custom build hook, so any copy-pasters find themselves already supporting custom Dockerfiles, rather than struggling with the same problem
2018-02-23 16:35:55 -08:00
Misty Stanley-Jones a4f5e30249
Various copyedits to reduce future tense, wordiness, and use of 'please' (#5788)
* Reword lots of instances of 'will'

* Reword lots of instances of won't

* Reword lots of instances of we'll

* Eradicate you'll

* Eradicate 'be able to' type of phrases

* Eradicate 'unable to' type of phrases

* Eradicate 'has / have to' type of phrases

* Eradicate 'note that' type of phrases

* Eradicate 'in order to' type of phrases

* Redirect to official Chef and Puppet docs

* Eradicate gratuitous 'please'

* Reduce use of e.g.

* Reduce use of i.e.

* Reduce use of N.B.

* Get rid of 'sexagesimal' and correct some errors
2018-01-25 17:37:23 -08:00
Alex Villarreal 017a919e03 Fix conflicting docs on single/multiple tags (#5561) 2017-12-19 13:09:21 -08:00
Victoria Bialas 3164a2a9ea fixed build command per user feedback (#3930)
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
2017-07-24 11:56:18 -07:00
Peter Kokot 0d5f1cfb8f Fix anchor to build time variables (#3601) 2017-06-19 11:56:48 -07:00
Victoria Bialas 9a4986465a Linked `docker build` in a Caution note (#3165)
Added an additional link to the `docker build` command topics per user feedback
2017-05-04 10:42:17 -07:00
Shubheksha Jalan 70593c8cd1 rename DOCKER_TAG to CACHE_TAG (#2959) 2017-04-20 12:08:13 -05:00
Cory Locklear 0bc81ae200 Fixes #2167. Added information about how docker cloud performs repo/branch clones, and potential work-arounds for those trying to utilize information from other branches in their builds. (#2890) 2017-04-20 12:06:33 -05:00
Victoria Bialas d67f1e3c4e tweak: code format for filename (#2829)
* tweak: code format for filename

slight reword, so as to avoid confusion w/filename

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* small changes just to kick build again

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
2017-04-17 14:25:12 -05:00
Shubheksha Jalan 8b3d0e2214 change pre-build to pre_build to remove confusion (#2813)
* change pre-build to pre_build to remove confusion

* clarify that pre_build hook refers to a file
2017-04-17 09:59:10 -07:00
Adrien Duermael 5b3cbf78f3 made absolute links to docs.docker.com relative
Signed-off-by: Adrien Duermael <adrien@duermael.com>
2016-12-27 10:44:36 -08:00
Micah Zoltu adfc2cbcbc Minor technical correction.
`$IMAGE_NAME` is actually `$DOCKER_REPO:$DOCKER_TAG`, not `$DOCKER_REPO/$DOCKER_TAG`.  This mistake confused me and made me think that `$DOCKER_REPO` was something like `index.docker.io/MyName` rather than `index.docker.io/MyName/MyProject`.
2016-11-19 13:22:01 -08:00
LRubin 260128dc73 removes references to autotest on push
Signed-off-by: LRubin <lrubin@docker.com>
2016-11-16 14:26:08 -08:00
Gaetan de Villele bcec1ddcb2 fix type of keywords entry in frontmatter (in /docker-cloud/ dir)
keywords should be a string, not an array containing one string

Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
2016-11-08 00:18:00 -08:00
John Mulhausen 558314bf56 Converges titles to imperative-form, front-matter based, and sentence-case (#438)
Multiple title fixes, consistency fixes, convergence into metadata-based titles.
2016-11-04 15:38:40 -07:00
Misty Stanley-Jones 1a193d749b Revert "Merge pull request #437 from gdevillele/fix_keywords_format"
This reverts commit 13ddc1350e, reversing
changes made to 7a11f05943.
2016-11-04 13:33:29 -07:00
Gaetan 8bb4d6226a fix more frontmatter keywords values (#439)
* fix format of frontmatter keyword entry in some .md files

Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
2016-11-04 10:48:38 -07:00
LRubin 12f95ada26 clarify use case for different types of env vars
Signed-off-by: LRubin <lrubin@docker.com>
2016-11-02 11:26:52 -07:00
LRubin 3760334084 fix formatting
Signed-off-by: LRubin <lrubin@docker.com>
2016-10-18 11:26:55 -07:00
LRubin 25d65e7c45 add webhooks examples
Signed-off-by: LRubin <lrubin@docker.com>
2016-10-13 13:16:54 -07:00
Misty Stanley-Jones d53c6798c9 Convert TOML to YAML, tweaks to work with Jekyll 2016-09-29 17:16:03 -07:00
Misty Stanley-Jones 978130dcf4 Moved docs to docker-cloud 2016-09-29 11:35:02 -07:00