The previous instructions fixed situations where the directory
and file didn't exist, but had some issues remaining;
The `>>` _appends_ the content to the file; this would work if the file didn't
exist (before `touch`'ing it) but if there happened to be a file already, it
would append the content to the existing file, resulting in invalid JSON.
e.g. running it twice (which may be accidentally);
```bash
sudo echo '{"allowedOrgs":["myorg"]}' >> "/Library/Application Support/com.docker.docker/registry.json"
sudo echo '{"allowedOrgs":["myorg"]}' >> "/Library/Application Support/com.docker.docker/registry.json"
```
Would result in;
```bash
sudo cat "/Library/Application Support/com.docker.docker/registry.json"
{"allowedOrgs":["myorg"]}
{"allowedOrgs":["myorg"]}
```
(which is invalid JSON)
The `sudo echo` also had some issues; the `sudo` only applied to the `echo`, and
not to the piped output (see https://unix.stackexchange.com/questions/1416/redirecting-stdout-to-a-file-you-dont-have-write-permission-on);
```bash
$ sudo touch "/Library/Application Support/com.docker.docker/registry.json"
$ sudo echo '{"allowedOrgs":["myorg"]}' > "/Library/Application Support/com.docker.docker/registry.json"
bash: /Library/Application Support/com.docker.docker/registry.json: Permission denied
```
Instead, using `tee` to run as privileged process, similar to the approach taken
in c33d39a7ba/engine/install/debian.md (L106)
With that, the `touch` wouldn't be needed (the `mkdir` still would though);
```suggestion
$ sudo mkdir -p "/Library/Application Support/com.docker.docker"
$ echo '{"allowedOrgs":["myorg"]}' | sudo tee "/Library/Application Support/com.docker.docker/registry.json"
```
The new instructions will always overwrite the content with the new content,
replacing what's already there (that may need a small warning / note though) to
prevent the invalid JSON if someone runs the command multiple times, or if they
have to update the existing config with a new one.
Finally, some verification steps were added to verify content and permissions.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Docker Desktop for Linux currently has a link to;
https://docs.docker.com/desktop/linux/#credentials-management
which has moved, and didn't have a redirect, causing the link to break;
unfortunately we can't fix existing versions of Docker Desktop; redirects
are being added (but won't be able to redirect to the correct anchor).
This patch adds a https://docs.docker.com/go/linux-credentials/ redirect,
so that we can continue using that URL even if content moves around.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Adds redirects for content that was removed in cab9f914bf
I tried to pick the most logical location, or following existing redirects (some of them
I wasn't sure about, e.g. most of the old "landing" page URLs looked to be redirected to
"get-started", not "desktop overview").
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* Fix use of bullet list
Otherwise it would read like so:
To summarize, a container: Containers are isolated from each other and run their own software, binaries, and configurations.
Alternatively, to keep it as a bullet point:
To summarize, a container:
...
is isolated from other containers and runs its own software, binaries, and configurations.
Both are correct. I can change the PR to the other option if preferred.
* Fix use of bullet list
Thanks, @craig-osterhout
As requested, here's the commit for the alternative. Please reject the other commit and accept this one.
CrazyMax
Sebastiaan van Stijn
Allie Sadler
Emmanuel Briney
Gavin
Justin Chadwell
Ivan Californias
Sebastiaan van Stijn
Usha Mandya
jerae-duffin
Craig Osterhout
CrazyMax
Dora Ribeiro
Peter Hauke
Jerae Duffin
craig-osterhout