Commit Graph

141 Commits

Author SHA1 Message Date
Usha Mandya 8d2682cac0
Merge pull request #13898 from humphd/patch-1
Update run-tests.md
2022-02-25 11:49:44 +00:00
Usha Mandya 1c402e7fbf
Merge pull request #14272 from ValeriiMakhniuk/patch-1
add link to volumes.md docs
2022-02-25 11:04:47 +00:00
Usha Mandya 9c63f89aac
Update language/nodejs/develop.md 2022-02-25 11:01:06 +00:00
OGUNSOLA USMAN ADEBAYO f5ed385f5b
Update develop.md (#14025)
* Update develop.md

- provided more clarity to the structure of the mongo database connection string used as CONNECTIONSTRING environment variable to run the docker image in the sample node.js project.

* Update develop.md
2022-02-24 14:15:46 +00:00
Usha Mandya 3d884a7138
Merge pull request #14235 from danBamikiya/configure-ci/cd-reorder
Ammend PAT setup section in Go language guide
2022-02-24 14:15:03 +00:00
Valerii Makhniuk 6617ca3c95
add link to volumes.md docs 2022-02-16 20:32:31 +03:00
Jake Levirne 3d9c6aff71
Minor typo - fixed case 2022-02-13 17:10:21 -05:00
Stefan Scherer bcc2a90f52
Use host port 8000 to avoid conflicts on Monterey
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
2022-02-09 13:05:34 +01:00
Dan Bámíkíyá 89ded65463
Ammend PAT setup section in Go language guide 2022-02-06 17:20:23 +01:00
Rayed Bin Wahed 122645e717
Update develop.md
Accidental subject-verb agreement error. Made the verb singular to agree with the singular subject Docker.
2022-02-02 12:00:38 +08:00
HARIHARAN E 65ddb87fd0
modify yoda_notes to notes at line 85 2022-01-21 12:49:03 +05:30
vuurball a93c040494
Update develop.md
typo fix
2022-01-16 14:30:06 +02:00
Usha Mandya 64cd649161
Merge pull request #14061 from bigsky-033/patch-1
Fix typo on PGDATABASE environment variable
2022-01-14 14:31:52 +05:30
Taemin Park 3d775401b8
Fix typo on PGDATABASE environment variable
Add colon on PGDATABASE
2021-12-31 17:05:18 +09:00
Kyle Martin 57b5a647ad
Very minor style update to included sample Python
Inconsequential and trivial change to ensure code in tutorial is consistently styled.
2021-12-27 19:20:04 -07:00
Santiago Rodriguez 2dd8f20546
small typo 2021-12-25 05:19:08 -04:00
David Humphrey 929daf72d6
Update run-tests.md
Fixed a couple of typos.
2021-11-26 21:32:20 -05:00
Dan Bamikiya 2452b40e9a
Remove usage of outdated `GHCR_TOKEN` (#13710)
* Remove usage of outdated GHCR_TOKEN

* Prefer {{ github.actor }} over {{ github.repository_owner }}

* Update language/java/configure-ci-cd.md with note about GITHUB_TOKEN

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>

* Update language/nodejs/configure-ci-cd.md with note about GITHUB_TOKEN

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>

* Update language/python/configure-ci-cd.md with note about GITHUB_TOKEN

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
2021-11-26 12:38:53 +00:00
Dan Bamikiya cc5d5db7c5
Explain the use of the `COPY` command in the NodeJS example (#13711)
* Explain the use of the COPY command in nodejs example

* Format updates

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
2021-11-19 12:18:37 +00:00
Usha Mandya 52d182a483
Merge pull request #13828 from rkbodenner/patch-1
Clearer purpose and contents for .dockerignore
2021-11-17 15:01:35 +00:00
Usha Mandya 57639274cd
Update build-images.md 2021-11-17 14:33:01 +00:00
Sebastiaan van Stijn a045d5d100
Merge pull request #13727 from califken/patch-2
Update run-containers.md
2021-11-11 15:02:18 +01:00
Ralph Bodenner b90deff361
Clearer purpose and contents for .dockerignore
I had to read the original paragraph a few times and search for docs on the file's purpose to understand what this step entailed. So here's another try at an explanation of what to do and why, with a hint about best practice.
2021-11-10 23:48:18 -08:00
seungwonleee 5131e29bfd Fix typo Language-specific guides / Nodejs / Run your tests 2021-11-06 02:30:41 +09:00
seungwonleee 0056623a58 Fix typo Language-specific guides / Nodejs / Run containers 2021-11-06 02:29:30 +09:00
Kenneth Caple f1242413b7
Update run-containers.md 2021-10-23 14:10:04 -07:00
Sebastiaan van Stijn d7e9ac275f
Some touch-ups in language get-started
- wrap lines in the java and golang getting started
- make the "test on the host" step in the Java getting started "optional". This
  allows users to try the tutorial without requiring them to set up a functional
  Java environment on their host. (i'm planning on making similar changes in
  the other language guides).
- use `docker <object> <action>` in some examples (but mention the corresponding
  shorthands); this may help understand the relation between the `<action>` and
  what kind of `<object>` we're acting on (tag an _image_, remove an _image_).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-10-13 16:30:58 +02:00
Usha Mandya d8a91fd44b
Merge pull request #13490 from mafreud/patch-1
Update run-containers.md
2021-10-04 10:46:59 +01:00
Usha Mandya 9a4eb3a8a6
Merge pull request #13507 from idjaw/update-docs-pip-freeze
Improves how requirements.txt is managed in Python tutorial #13506
2021-10-04 10:06:09 +01:00
Stan Manilov 3e5032813f Remove outdated sentence
The output following the sentence no longer contains what the sentence
claims.
2021-09-16 22:18:57 +03:00
Wajdi Al-Hawari a9a8311643 Improves how requirements.txt is created
- To reduce the error prone process of grabbing all Python packages in the global Python scope, the specific package is extracted and set in to the requirements.txt file
2021-09-11 16:30:23 -04:00
Masahiro Aoki 9dd353952b
Update run-containers.md 2021-09-09 13:54:54 +09:00
Sebastiaan van Stijn fbd8c365c8
language/nodejs: un-wrap JSON in example to allow copying
The JSON string was wrapped, causing the highlighter to consider it "output",
which cannot be selected/copied in "console" blocks.

This unwraps the JSON so that it can be copied.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-09-02 16:56:29 +02:00
Sebastiaan van Stijn 81177c8b02
fix language guides markup
- force "nowrap"
- add "col-xs-12" to fix size on smaller sizes
- remove the "component-icon" div, as it was not styled

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-09-02 13:53:22 +02:00
Sebastiaan van Stijn 60709ed648
Merge pull request #13423 from arvind-007/patch-1
Update build-images.md
2021-08-27 16:05:39 +02:00
Usha Mandya 2feae0d569
Merge pull request #13410 from thaJeztah/go_get_started_touchups
guides: use include for "create a Dockerfile" sections
2021-08-27 14:54:49 +01:00
arvind-007 23b029e358
Update build-images.md 2021-08-27 15:27:55 +05:30
Sebastiaan van Stijn d1fbf5c959
guides: use include for "create a Dockerfile" sections
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-25 13:42:32 +02:00
shayan-7 2b5a5618a1
Found more typos and grammar issues 2021-08-23 22:04:22 +04:30
shayan-7 6a118534ab
Fix a typo 2021-08-23 21:06:00 +04:30
Sebastiaan van Stijn 1583678203
Add missing code-hints, and minor markdown edits
- Add missing code-hints (console, yaml)
- Consistently add an empty line after code-blocks
- Combine some examples where the output and the command were
  put in separate blocks. With the "console" code-hint, this
  is no longer nescessary.
- fix indentation in cloud/ecs-integration.md, which caused the
  numbered-list to be interrupted.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-16 12:59:23 +02:00
kurama f4655fb89e
fix: typo (#13348)
* fix: typo

* Minor style updates

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
2021-08-16 11:57:31 +01:00
DJ Adams 5dd725fb4f
add explicit instruction to stop local server (#13235)
* add explicit instruction to stop local server

This relates to the [Test the application section of the Build images tutorial](https://docs.docker.com/language/nodejs/build-images/#test-the-application). 

In this section, `node server.js` is used to start the server locally. The reader is not instructed to stop the server. 

In the [Run containers](https://docs.docker.com/language/nodejs/run-containers/) tutorial that follows this one, the reader is instructed to start up the container, and try to access `http://localhost:8000/test` which is now being served from the Node.js process inside the container. However, if the local Node.js process from the `node server.js` invocation earlier, they won't see the "Failed to connect to localhost port 8000" error which they're supposed to see. 

So this modification adds an explicit instruction to the "Build containers" tutorial to stop the `node server.js` process, to avoid any potential confusion in the "Run containers" tutorial.

Great tutorials, btw!

* show what happens with Ctrl-c

add suggestions from @thaJeztah, plus the same language identifier on the triple-backtick quoted output earlier (`console`).

* Minor styling updates

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
2021-08-09 11:26:37 +01:00
Sebastiaan van Stijn 74460241f8
language/python: use "console" for shell examples
This allows for easier copying of the commands, without selecting the
prompt.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-06 17:20:00 +02:00
Sebastiaan van Stijn 60bb48a6a1
language/nodejs: use "console" for shell examples
This allows for easier copying of the commands, without selecting the
prompt.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-06 17:19:59 +02:00
Sebastiaan van Stijn 38b629bcb2
language/java: use "console" for shell examples
This allows for easier copying of the commands, without selecting the
prompt.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-06 17:19:58 +02:00
Sebastiaan van Stijn 0ceace875d
language/golang: use "console" for shell examples
This allows for easier copying of the commands, without selecting the
prompt.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-06 17:19:58 +02:00
Sebastiaan van Stijn 7e9fdf93fe
language/golang: fix some broken links
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-08-06 11:52:13 +02:00
Jerae Duffin 326b8efe9e updated volumes link 2021-08-05 21:58:55 -05:00
Jerae Duffin ed5cad4884 fixed broken link 2021-08-05 21:48:27 -05:00