The `ENV key value` form can be ambiguous, for example, the following defines
a single env-variable (`ONE`) with value `"TWO= THREE=world"`:
ENV ONE TWO= THREE=world
While we cannot deprecate/remove that syntax (as it would break existing
Dockerfiles), we should reduce exposure of the format in our examples.
Also updating some code-blocks that were missing language-hints
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* Update docs on command help
This is change is based on the output of the script proposed by @smola
in: https://github.com/docker/docker.github.io/pull/11173
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
* Formatting updates
* Minor style update
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
* Add note about setup beeing not viable production
I think there should at least a small hint that this guide is just intended as a bare-bones development environment and should not at all be rolled into production like this.
Relates to #7622
* Minor style updates
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
* Update gettingstarted.md
1. Flask app was running in the wrong port.
2. 5000 port was not exposed in Dockerfile
* Update gettingstarted.md
mistook Redis port to flask port.
### Background
Newer upstream PostgreSQL Docker images, now require a password for use. If you were previously using passwordless access to a PostgreSQL DB, it will likely fail with an error.
This linked GitHub issue showcases the error:
https://github.com/docker-library/postgres/issues/681
### Solution
The postgres docker page gives instructions on how to use the new image : https://hub.docker.com/_/postgres
There seems to be two different options we can take here :
Option 1 - Implement a password using the environment variable
Option 2 - Revert back to old behavior of having no password requirement
### Thoughts
Based on the team members remark it looks like increased security was the major reason for this breaking changing happening in a minor update. Refer to this comment : https://github.com/docker-library/postgres/issues/681#issuecomment-586517154
As such I opted to use Option 1 here in this change as increased security of a DB is generally a win for every one in most cases.
Unfortunately, the only reliable way to create internal links
is to use relative links to other Markdown files. This does
match the way links on GitHub work, but makes it harder to
create these links.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Anca Iordache
Sebastiaan van Stijn
Usha Mandya
aiordache
Ulysses Souza
Usha Mandya
Muma David Bwalya
Sohrab Shahinfar
Mark Schmale
Geetha Rangaswamaiah
Melanie Kwon
Vemuluru Venkata Sri Harsha
Kaden Weber
Jason C
David Florness
Alan Bondarchuk
Sebastiaan van Stijn
Aleksandr Prusov
Aravind
Daniel Martinez Sarta
ticalcster
Dale Seo
Beni Rupp
Sven Dowideit
Young Jin Ahn