I had to read the original paragraph a few times and search for docs on the file's purpose to understand what this step entailed. So here's another try at an explanation of what to do and why, with a hint about best practice.
- wrap lines in the java and golang getting started
- make the "test on the host" step in the Java getting started "optional". This
allows users to try the tutorial without requiring them to set up a functional
Java environment on their host. (i'm planning on making similar changes in
the other language guides).
- use `docker <object> <action>` in some examples (but mention the corresponding
shorthands); this may help understand the relation between the `<action>` and
what kind of `<object>` we're acting on (tag an _image_, remove an _image_).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- To reduce the error prone process of grabbing all Python packages in the global Python scope, the specific package is extracted and set in to the requirements.txt file
The JSON string was wrapped, causing the highlighter to consider it "output",
which cannot be selected/copied in "console" blocks.
This unwraps the JSON so that it can be copied.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- force "nowrap"
- add "col-xs-12" to fix size on smaller sizes
- remove the "component-icon" div, as it was not styled
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Add missing code-hints (console, yaml)
- Consistently add an empty line after code-blocks
- Combine some examples where the output and the command were
put in separate blocks. With the "console" code-hint, this
is no longer nescessary.
- fix indentation in cloud/ecs-integration.md, which caused the
numbered-list to be interrupted.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
* add explicit instruction to stop local server
This relates to the [Test the application section of the Build images tutorial](https://docs.docker.com/language/nodejs/build-images/#test-the-application).
In this section, `node server.js` is used to start the server locally. The reader is not instructed to stop the server.
In the [Run containers](https://docs.docker.com/language/nodejs/run-containers/) tutorial that follows this one, the reader is instructed to start up the container, and try to access `http://localhost:8000/test` which is now being served from the Node.js process inside the container. However, if the local Node.js process from the `node server.js` invocation earlier, they won't see the "Failed to connect to localhost port 8000" error which they're supposed to see.
So this modification adds an explicit instruction to the "Build containers" tutorial to stop the `node server.js` process, to avoid any potential confusion in the "Run containers" tutorial.
Great tutorials, btw!
* show what happens with Ctrl-c
add suggestions from @thaJeztah, plus the same language identifier on the triple-backtick quoted output earlier (`console`).
* Minor styling updates
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
* Update build-images.md
Small typos in the documentation, which may lead to confusion.
* Inspiration from node.js docs
Added documentation for why we copy `package*.json` before copying the whole directory. Checkout: https://nodejs.org/en/docs/guides/nodejs-docker-webapp/#creating-a-dockerfile.
The node.js docs has more optimized code too (using `npm ci` instead of `npm install`) which can be used here too.
* Fixed review provided and removed some weird whitespaces
Dan Bamikiya
Usha Mandya
Sebastiaan van Stijn
Ralph Bodenner
seungwonleee
Kenneth Caple
Sebastiaan van Stijn
Stan Manilov
Wajdi Al-Hawari
Masahiro Aoki
arvind-007
shayan-7
kurama
DJ Adams
Jerae Duffin
Usha Mandya
dodsonmg
Aaryan Porwal
Nahin Khan
jerae-duffin