Commit Graph

87 Commits

Author SHA1 Message Date
Eric Bloch 96c904a51e Add tcsh support to --shell
Fixes #3404

Signed-off-by: Eric Bloch <eric.bloch@gmail.com>
2016-05-04 20:29:07 -07:00
John Sirois 705865fa70 Fixup create command flag application.
Previously StringSlice flag defaults were not respected.  These use
special handling and that handling did not take account of default
values, always over-writing them.  Expand the CommandLine interface to
take advantage of the underlying codegansta/cli.Context IsSet method and
guard default string slice overwrites with an IsSet test.

Signed-off-by: John Sirois <john.sirois@gmail.com>
2016-03-29 11:53:22 -06:00
David Gageot e3ff59bd92 Export flags for consumers of libmachine
Signed-off-by: David Gageot <david@gageot.net>
2016-03-02 22:27:59 +01:00
David Gageot 7a6ca308c4 FIX #3016 Add timeout to active command
Signed-off-by: David Gageot <david@gageot.net>
2016-02-11 13:55:52 -08:00
David Gageot 834b9b4161 FIX #2982 Fix auto detection
Signed-off-by: David Gageot <david@gageot.net>
2016-02-03 08:23:12 -08:00
Nathan LeClaire d27ccb0f6e Exit with code 3 if error is during pre-create check
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2016-02-02 16:08:57 -08:00
Nathan LeClaire 0118532393 Reset default shell for env to bash
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2016-01-28 12:11:22 -08:00
David Gageot 501b8666ce Merge pull request #2121 from nathanleclaire/provision_cmd
Add docker-machine provision command
2016-01-18 08:53:15 +01:00
Nathan LeClaire 5000139c8e Add ability to imply 'default' VM in commands
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2016-01-15 17:10:08 -08:00
Nathan LeClaire 01c7556e3a Add docker-machine provision command
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2016-01-12 11:52:36 -08:00
Jean-Laurent de Morlhon 45a8f5e7a6 Returns exit code 3 on pre-create check
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
2016-01-12 11:04:39 +01:00
David Gageot f96595d7d0 Fix Bugnag Report not being sent
Signed-off-by: David Gageot <david@gageot.net>
2016-01-07 12:09:00 +01:00
David Gageot f5293e10e2 Crash reporting shouldn't be static
Signed-off-by: David Gageot <david@gageot.net>
2016-01-05 18:16:11 +01:00
David Gageot cd9301e252 Merge pull request #2730 from dgageot/close-api
Close api
2016-01-05 15:50:44 +01:00
Nathan LeClaire e0570c0c2b Merge pull request #2702 from dgageot/ls-format
Add --format, -f flag to ls command
2016-01-04 14:22:43 -08:00
David Gageot d771d65dc4 Merge pull request #2734 from dgageot/shell-detect-package
Extract shell detection to its own package
2016-01-04 16:14:21 +01:00
David Gageot 5ff7ab91fb Extract shell detection to its own package
Signed-off-by: David Gageot <david@gageot.net>
2016-01-04 15:58:30 +01:00
David Gageot 263f8c5cdd Remove duplication
Signed-off-by: David Gageot <david@gageot.net>
2016-01-04 14:59:25 +01:00
David Gageot 67f8b19c9b Don't use global variables. Make the Api closeable
Signed-off-by: David Gageot <david@gageot.net>
2016-01-04 14:59:15 +01:00
David Gageot 5cfdcfe7b6 Remove duplication on certificates code
Signed-off-by: David Gageot <david@gageot.net>
2016-01-04 10:40:21 +01:00
David Gageot adc60712c8 Allow custom format for ls
Signed-off-by: David Gageot <david@gageot.net>
2015-12-28 17:15:07 +01:00
David Gageot 89d9e2fe90 Close drivers on exit
Signed-off-by: David Gageot <david@gageot.net>
2015-12-24 13:44:42 +01:00
Jean-Laurent de Morlhon 02dde087c9 Merge pull request #2552 from nathanleclaire/ls_timeout_nits
Aesthetic nitpicks on ls timeout
2015-12-11 10:55:40 +01:00
Nathan LeClaire 5358010229 Merge pull request #2526 from jeanlaurent/bugsnag
Monitor and report bug with bugsnag
2015-12-10 19:01:22 -08:00
Nathan LeClaire 29ffc04cc9 Aesthetic nitpicks on ls timeout
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2015-12-10 13:25:13 -08:00
Jean-Laurent de Morlhon 4f0c24483b bugsnag integration
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
2015-12-10 17:05:05 +01:00
Jean-Laurent de Morlhon 02c235b8b9 Fix #2534 and #1696
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
2015-12-10 16:51:59 +01:00
Jean-Laurent de Morlhon f37a0290dd Add shell list to help command
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
2015-12-09 09:46:03 +01:00
Anil Belur a2a9ebb078 Minor fix updating the sub-command rm usage with -f.
This is a follow up for #2349

Signed-off-by: Anil Belur <askb23@gmail.com>
2015-12-08 16:55:54 +05:30
David Gageot 3612c55677 Add version to machine ls
Signed-off-by: David Gageot <david@gageot.net>
2015-12-03 16:27:42 +01:00
Jean-Laurent de Morlhon f9f886f529 Display driver in error without crashing
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
2015-12-02 18:27:21 +01:00
Anil Belur 77fba72d13 Fixes #2349 - rm get user confirmation before proceeding further
* adds new flag `-y` prompting for user confirmation before removal
* Modified existing integration tests to work with the fix #2349.
* Added tests for checking user confirmation, updated the test cases use sub-shell with `|`
* Updated the reference docs for rm sub-command

incorporated changes by @dgageot, @jeanlaurent and @nathanleclaire

Signed-off-by: Anil Belur <askb23@gmail.com>
2015-12-02 09:17:33 +05:30
Nathan LeClaire 19ce7b79bd Revise CommandLine interface to contain libmachine client and store
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2015-11-23 19:29:20 -08:00
Nathan LeClaire 42b6249a8c Vendor codegangsta/cli properly
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2015-11-20 18:20:11 -08:00
David Gageot e537a51926 Merge pull request #2352 from jeanlaurent/better-cli
Fix create usage & description in cli
2015-11-19 13:39:02 +01:00
Jean-Laurent de Morlhon 1521fed1ed Add a version command
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
2015-11-19 12:42:32 +01:00
Jean-Laurent de Morlhon 91b64ff913 Fix create usage & description in cli
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
2015-11-19 12:19:56 +01:00
David Gageot eb39f098d5 Move code where it's used
Signed-off-by: David Gageot <david@gageot.net>
2015-11-13 16:27:50 +01:00
David Gageot 8bbfc6ef2a Remove unused code
Signed-off-by: David Gageot <david@gageot.net>
2015-11-13 16:27:50 +01:00
Olivier Gambier 89d9854943 Another pass at linting
Signed-off-by: Olivier Gambier <olivier@docker.com>
2015-11-10 16:58:14 +01:00
David Gageot 68092b3524 FIX #2154 query virtualbox serially
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2015-11-07 16:14:25 +01:00
Olivier Gambier d2ada6488c Lint
Signed-off-by: Olivier Gambier <olivier@docker.com>
2015-11-05 13:34:07 -08:00
David Gageot 99d6fe134d Introduce CommandLine interface
Signed-off-by: David Gageot <david@gageot.net>
2015-11-05 06:07:57 +01:00
Olivier Gambier 19fc49b58a Lint, step 1
The easy stuff

Signed-off-by: Olivier Gambier <olivier@docker.com>
2015-11-04 14:17:58 -08:00
Nathan LeClaire 9a4bc9a20d Ensure that ls will still work when plugin cannot be found
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2015-11-03 11:35:30 -08:00
Nathan LeClaire 060f0a0db2 Fix issues with create and ssh command help text
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2015-10-30 16:21:47 -07:00
David Gageot 86c52ec3e7 Make commands code easier to test
Signed-off-by: David Gageot <david@gageot.net>
2015-10-29 11:15:17 +01:00
Nathan LeClaire c04eb43021 Remove redundant error log
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2015-10-28 13:56:29 -07:00
Nathan LeClaire 76c7accda0 Add heartbeat / automatic server cleanup code
This replaces the previous method of attempting to clean up servers when
an unexpected exit occurs in the client (e.g. SIGINT or panic) by a
heartbeat protocol.  If the server does not hear from the connecting
client within a certain interval of time (500ms in this commit), it will
de-activate itself.  This prevents dangling Docker Machine server
processes from accumulating.

Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
2015-10-22 19:44:35 -07:00
David Gageot 6bbec2df68 Report VirtualBox errors
Signed-off-by: David Gageot <david@gageot.net>
2015-10-21 21:03:51 +02:00