docker
/
docs
mirror of https://github.com/docker/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
docs/integration-cli
History
Yong Tang ee4bd806ba API/CLI discrepancy on hostname validation (#21595). 
This fix tries to fix the discrepancy between API and CLI on hostname
validation. Previously, the hostname validation was handled at the
CLI interface in runconfig/opts/parse.go and return an error if the
hostname is invalid. However, if an end user use the remote API to
pass the hostname, the error will not be returned immediately.
Instead the error will only be thrown out when the container creation
fails. This creates behavior discrepancy between API and CLI.

In this fix, the hostname validation was moved to
verifyContainerSettings so the behavior will be the same for API and
CLI.

After the change, since CLI does not handle the hostname validation
any more, the previous unit tests about hostname validation on CLI
in runconfig/opts/parse_test.go has to be updated as well because
there is no validation at this stage. All those unit tests are moved
to integration test TestRunTooLongHostname so that the hostname
validation is still properly covered as before.

Note: Since the hostname validation moved to API, the error message
changes from `invalid hostname format for --hostname:` to
`invalid hostname format:` as well because `--hostname` is passed
to CLI only.

This fix fixes #21595.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
 		2016-04-08 06:13:08 +00:00
..
fixtures Trusted push now adds the tag to every first level delegation role for which we have keys 2016-03-21 10:56:09 -07:00
benchmark_test.go Move layer mount refcounts to mountedLayer 2016-03-23 14:42:52 -07:00
check_test.go Add test for targets/releases preference when pulling 2016-03-21 10:56:42 -07:00
daemon.go Merge pull request #21599 from tonistiigi/separate-daemon-exec-root 2016-03-29 07:52:18 -07:00
docker_api_attach_test.go Let client print error when speicify wrong detach keys 2016-04-04 15:35:55 +08:00
docker_api_build_test.go
…
docker_api_containers_test.go Remove dot in suffix to avoid double dot error message 2016-03-22 09:17:54 +08:00
docker_api_create_test.go Fix error message in container creation 2016-01-25 11:45:20 -08:00
docker_api_events_test.go Windows CI: Integrity check for busybox top 2016-02-24 11:00:47 -08:00
docker_api_exec_resize_test.go Remove exec-driver global daemon option. 2015-11-05 17:09:58 -05:00
docker_api_exec_test.go Fix TestExecApiStartWithDetach on WindowsTP4 2016-02-25 14:27:22 +01:00
docker_api_images_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_api_info_test.go Added additional container information to "docker info". 2016-01-11 19:14:44 -05:00
docker_api_inspect_test.go Windows CI: PortTestInspectApi* 2016-01-26 20:23:40 -08:00
docker_api_inspect_unix_test.go Checkers on docker_api_inspect_unix_test.go 2015-11-23 22:03:14 -05:00
docker_api_logs_test.go Windows CI Reliablity: TestLogsApiWithStdout 2016-03-02 10:26:15 -08:00
docker_api_network_test.go Remove runconfig dependency from network routes. 2016-03-28 16:23:50 -04:00
docker_api_resize_test.go Windows CI: Port docker_api_resize_test.go 2016-02-03 20:30:06 -08:00
docker_api_stats_test.go Optimize TestApiStatsNetworkStats and TestApiStatsNetworkStatsVersioning 2016-02-01 10:26:27 +08:00
docker_api_test.go Support TLS remote test daemon 2016-02-25 14:12:17 -05:00
docker_api_update_unix_test.go Fix minor vet warnings 2016-02-03 10:43:01 -08:00
docker_api_version_test.go Modify import paths to point to the new engine-api package. 2016-01-06 19:48:59 -05:00
docker_api_volumes_test.go integration-cli: remove not necessary -d again 2016-02-28 13:48:15 +01:00
docker_cli_attach_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_cli_attach_unix_test.go Improve remote integration-cli tests 2016-02-11 07:31:49 -08:00
docker_cli_authz_unix_test.go Extend Docker authorization with TLS user information 2016-03-27 15:53:55 +03:00
docker_cli_build_test.go Apply build labels to images with only a FROM tag. 2016-03-30 17:28:13 -04:00
docker_cli_build_unix_test.go Fix events test flakiness. 2016-02-18 16:10:29 -05:00
docker_cli_by_digest_test.go integration-cli: remove not necessary -d again 2016-02-28 13:48:15 +01:00
docker_cli_commit_test.go Vendor engine-api to 70d266e96080e3c3d63c55a4d8659e00ac1f7e6c 2016-02-29 19:28:37 +08:00
docker_cli_config_test.go Support TLS remote test daemon 2016-02-25 14:12:17 -05:00
docker_cli_cp_from_container_test.go
…
docker_cli_cp_test.go Windows CI: Deal with failing tests for TP4 2016-01-08 13:49:43 -08:00
docker_cli_cp_to_container_test.go Fix typos found across repository 2015-12-13 18:04:12 +02:00
docker_cli_cp_to_container_unix_test.go Fix copy chown settings to not default to real root 2016-02-18 14:44:13 -08:00
docker_cli_cp_utils.go
…
docker_cli_create_test.go fix TestCreateShrinkRootfs and TestCreateShrinkRootfs 2016-04-06 12:40:20 -04:00
docker_cli_daemon_experimental_test.go Update mount state of live containers after a daemon crash. 2016-03-29 14:42:43 -07:00
docker_cli_daemon_not_experimental_test.go Update mount state of live containers after a daemon crash. 2016-03-29 14:42:43 -07:00
docker_cli_daemon_test.go Merge pull request #21372 from anusha-ragunathan/ctrd-rebase 2016-03-30 23:10:04 -07:00
docker_cli_diff_test.go integration-cli: fix wrong test and add log 2016-03-24 11:10:41 +01:00
docker_cli_events_test.go integration-cli: try to make TestEventsTimestampFormats less flaky 2016-04-06 14:31:39 -07:00
docker_cli_events_unix_test.go Fix flaky OOM tests 2016-02-23 15:26:26 -05:00
docker_cli_exec_test.go Add ulimit support to libcontainerd addprocess 2016-03-23 19:54:32 -07:00
docker_cli_exec_unix_test.go Revert hack in TestExecTTY 2016-03-08 10:54:18 +08:00
docker_cli_experimental_test.go Move userns cli test to a separate file, remove experimental flag 2016-02-09 09:31:09 +02:00
docker_cli_export_import_test.go
…
docker_cli_external_graphdriver_unix_test.go CLI flag for docker create(run) to change block device size. 2016-03-28 10:05:18 -04:00
docker_cli_help_test.go Support TLS remote test daemon 2016-02-25 14:12:17 -05:00
docker_cli_history_test.go Optimize slow bottleneck test of DockerSuite.TestBuildHistory. 2016-03-02 20:37:47 +00:00
docker_cli_images_test.go Fix image filter 2016-01-14 08:17:40 +00:00
docker_cli_import_test.go Fix docker import on compressed data 2016-02-16 11:19:23 -08:00
docker_cli_info_test.go Add insecure registries to docker info 2016-03-31 08:27:24 +02:00
docker_cli_inspect_experimental_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_cli_inspect_test.go Expose RootFS in image inspect 2016-03-22 13:49:30 -07:00
docker_cli_kill_test.go Windows CI: Port TestKill* 2016-02-24 13:33:25 -08:00
docker_cli_links_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_cli_links_unix_test.go
…
docker_cli_login_test.go distribution: errors: do not access the errors slice if it's empty 2016-03-16 09:00:39 +01:00
docker_cli_logout_test.go Change v1 pull 404 message to include tag 2016-03-29 10:04:59 -07:00
docker_cli_logs_bench_test.go Fixes some issues with jsonfile write/read 2016-03-21 11:05:58 -04:00
docker_cli_logs_test.go integration-cli: move goroutines info helpers to separate funcs 2016-03-14 15:52:56 -07:00
docker_cli_nat_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_cli_netmode_test.go Re-enable shared namespace tests for userns CI runs 2016-03-23 09:39:24 -04:00
docker_cli_network_unix_test.go Fix Docker core dumps when removing network with special characters (#21401). 2016-03-23 15:07:14 -04:00
docker_cli_oom_killed_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_cli_pause_test.go Windows CI: Deal with failing tests for TP4 2016-01-08 13:49:43 -08:00
docker_cli_port_test.go Expose bridge IPv6 setting to `docker network inspect` 2016-02-11 22:13:47 +00:00
docker_cli_proxy_test.go Support TLS remote test daemon 2016-02-25 14:12:17 -05:00
docker_cli_ps_test.go do not trim one char from {{.Names}} each time it is used in --format 2016-04-06 11:04:13 -07:00
docker_cli_pull_local_test.go distribution: errors: do not access the errors slice if it's empty 2016-03-16 09:00:39 +01:00
docker_cli_pull_test.go Change v1 pull 404 message to include tag 2016-03-29 10:04:59 -07:00
docker_cli_pull_trusted_test.go Pull, Pull-A, and Build will only pull tags from the targets role or the targets/releases role. 2016-03-21 10:56:49 -07:00
docker_cli_push_test.go test: Do not check error message from hub, it is not needed 2016-03-23 14:11:44 -04:00
docker_cli_registry_user_agent_test.go Pass upstream client's user agent through to registry on operations beyond pulls 2016-03-21 14:31:47 -07:00
docker_cli_rename_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_cli_restart_test.go Fix restart monitor stopping on manual restart 2016-04-07 16:12:05 -07:00
docker_cli_rm_test.go Merge pull request #19959 from WeiZhang555/fix-cli-print-err 2016-02-03 10:56:19 -08:00
docker_cli_rmi_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_cli_run_test.go API/CLI discrepancy on hostname validation (#21595). 2016-04-08 06:13:08 +00:00
docker_cli_run_unix_test.go Let client print error when speicify wrong detach keys 2016-04-04 15:35:55 +08:00
docker_cli_save_load_test.go Fix flaky TestSaveLoadParents 2016-04-06 21:58:47 -07:00
docker_cli_save_load_unix_test.go Assert error in body of function `inspectField*` 2016-01-29 23:39:07 +08:00
docker_cli_search_test.go
…
docker_cli_sni_test.go Disable flakey TestClientSetsTLSServerName 2016-02-02 19:56:31 -08:00
docker_cli_start_test.go Better logging for errors in some tests 2016-03-25 10:02:52 -04:00
docker_cli_start_volume_driver_unix_test.go integration-cli: fixups 2016-03-03 11:51:59 +01:00
docker_cli_stats_test.go Bug fix: stats --no-stream always print zero values 2016-03-05 13:22:26 +08:00
docker_cli_tag_test.go Allow uppercase characters in image reference hostname 2016-02-10 14:03:41 -08:00
docker_cli_top_test.go
…
docker_cli_update_test.go Fix flaky TestUpdateRestartPolicy on Windows 2016-03-14 12:49:24 +01:00
docker_cli_update_unix_test.go Add pause status check for --kernel-memory 2016-04-01 10:32:46 +08:00
docker_cli_userns_test.go Run privileged containers when userns are specified 2016-03-14 17:09:25 +02:00
docker_cli_v2_only_test.go Login update and endpoint refactor 2016-03-01 11:52:32 -08:00
docker_cli_version_test.go Build and test Docker on IBM Power and Z using gccgo. Enable CI on Power and Z. 2015-11-14 03:16:45 +00:00
docker_cli_volume_test.go Add name/driver filter support for volume 2016-03-25 01:11:17 +00:00
docker_cli_wait_test.go Better logging for errors in some tests 2016-03-25 10:02:52 -04:00
docker_experimental_network_test.go Add "--ipv6" flag in IT for network create when using ipv6 subnets 2016-03-24 16:19:59 -07:00
docker_hub_pull_suite_test.go
…
docker_test_vars.go fix test requirement about devicemapper and not overlay 2016-04-06 12:40:19 -04:00
docker_utils.go fix test requirement about devicemapper and not overlay 2016-04-06 12:40:19 -04:00
events_utils.go Compare event nanoseconds properly to filter since a specific date. 2016-03-08 17:07:58 -05:00
npipe.go Windows CI: Allow npipe protocol for sock requests 2016-03-02 14:22:51 -08:00
npipe_windows.go Windows CI: Allow npipe protocol for sock requests 2016-03-02 14:22:51 -08:00
registry.go distribution: errors: do not access the errors slice if it's empty 2016-03-16 09:00:39 +01:00
registry_mock.go integration-cli: log error when starting registry 2016-01-11 20:16:13 +01:00
requirements.go fix test requirement about devicemapper and not overlay 2016-04-06 12:40:19 -04:00
requirements_unix.go pids limit support 2016-03-08 07:55:01 -08:00
test_vars_exec.go
…
test_vars_noexec.go
…
test_vars_noseccomp.go Allow non-seccomp platforms to pass integration-cli tests 2015-12-07 20:14:52 -05:00
test_vars_seccomp.go Allow non-seccomp platforms to pass integration-cli tests 2015-12-07 20:14:52 -05:00
test_vars_unix.go Factorize sleeping containers 2016-01-27 08:48:08 -08:00
test_vars_windows.go Fixing flaky tests on Windows (again) 2016-03-11 14:48:52 -08:00
trust_server.go vendor notary for docker1.11 2016-03-22 11:28:19 -07:00
utils.go Add a getPrefixAndSlashFromDaemonPlatform … 2016-02-03 15:16:00 +01:00