feat: fixed the comments for PersistentCacheTask (#396)

Signed-off-by: Gaius <gaius.qi@gmail.com>
This commit is contained in:
Gaius 2024-09-29 14:18:23 +08:00 committed by GitHub
parent 0b031ea044
commit cc23703438
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 6 deletions

View File

@ -144,7 +144,8 @@ message PersistentCachePeer {
string id = 1 [(validate.rules).string.min_len = 1]; string id = 1 [(validate.rules).string.min_len = 1];
// Persistent represents whether the persistent cache peer is persistent. // Persistent represents whether the persistent cache peer is persistent.
// If the persistent cache peer is persistent, the persistent cache peer will // If the persistent cache peer is persistent, the persistent cache peer will
// not be deleted when dfdaemon runs garbage collection. // not be deleted when dfdaemon runs garbage collection. It only be deleted
// when the task is deleted by the user.
bool persistent = 2; bool persistent = 2;
// Peer downloads costs time. // Peer downloads costs time.
google.protobuf.Duration cost = 3 [(validate.rules).duration.required = true]; google.protobuf.Duration cost = 3 [(validate.rules).duration.required = true];
@ -208,9 +209,12 @@ message Task {
message PersistentCacheTask { message PersistentCacheTask {
// Task id. // Task id.
string id = 1 [(validate.rules).string.min_len = 1]; string id = 1 [(validate.rules).string.min_len = 1];
// Replica count of the persistent cache task. // Replica count of the persistent cache task. The persistent cache task will
// not be deleted when dfdamon runs garbage collection. It only be deleted
// when the task is deleted by the user.
uint64 persistent_replica_count = 2 [(validate.rules).uint64.gte = 1]; uint64 persistent_replica_count = 2 [(validate.rules).uint64.gte = 1];
// Replica count of the persistent cache task. // Replica count of the cache task. If cache task is not persistent,
// the persistent cache task will be deleted when dfdaemon runs garbage collection.
uint64 replica_count = 3 [(validate.rules).uint64.gte = 1]; uint64 replica_count = 3 [(validate.rules).uint64.gte = 1];
// Digest of the task digest, for example blake3:xxx or sha256:yyy. // Digest of the task digest, for example blake3:xxx or sha256:yyy.
string digest = 4 [(validate.rules).string = {pattern: "^(md5:[a-fA-F0-9]{32}|sha1:[a-fA-F0-9]{40}|sha256:[a-fA-F0-9]{64}|sha512:[a-fA-F0-9]{128}|blake3:[a-fA-F0-9]{64}|crc32:[a-fA-F0-9]{8})$"}]; string digest = 4 [(validate.rules).string = {pattern: "^(md5:[a-fA-F0-9]{32}|sha1:[a-fA-F0-9]{40}|sha256:[a-fA-F0-9]{64}|sha512:[a-fA-F0-9]{128}|blake3:[a-fA-F0-9]{64}|crc32:[a-fA-F0-9]{8})$"}];

View File

@ -138,7 +138,8 @@ message PersistentCachePeer {
string id = 1; string id = 1;
// Persistent represents whether the persistent cache peer is persistent. // Persistent represents whether the persistent cache peer is persistent.
// If the persistent cache peer is persistent, the persistent cache peer will // If the persistent cache peer is persistent, the persistent cache peer will
// not be deleted when dfdaemon runs garbage collection. // not be deleted when dfdaemon runs garbage collection. It only be deleted
// when the task is deleted by the user.
bool persistent = 2; bool persistent = 2;
// Peer downloads costs time. // Peer downloads costs time.
google.protobuf.Duration cost = 3; google.protobuf.Duration cost = 3;
@ -202,9 +203,12 @@ message Task {
message PersistentCacheTask { message PersistentCacheTask {
// Task id. // Task id.
string id = 1; string id = 1;
// Replica count of the persistent cache task. // Replica count of the persistent cache task. The persistent cache task will
// not be deleted when dfdamon runs garbage collection. It only be deleted
// when the task is deleted by the user.
uint64 persistent_replica_count = 2; uint64 persistent_replica_count = 2;
// Replica count of the persistent cache task. // Replica count of the cache task. If cache task is not persistent,
// the persistent cache task will be deleted when dfdaemon runs garbage collection.
uint64 replica_count = 3; uint64 replica_count = 3;
// Digest of the task digest, for example blake3:xxx or sha256:yyy. // Digest of the task digest, for example blake3:xxx or sha256:yyy.
string digest = 4; string digest = 4;