From 9eb15b218d56ec19e3cf1745cd18c0e01089f355 Mon Sep 17 00:00:00 2001 From: Jim Ma Date: Thu, 21 Sep 2023 21:04:17 +0800 Subject: [PATCH] fix: overhead gc when DiskGCThreshold not set (#2750) Signed-off-by: Jim Ma --- client/daemon/storage/storage_manager.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/client/daemon/storage/storage_manager.go b/client/daemon/storage/storage_manager.go index 1d2e28979..b5cff0bbd 100644 --- a/client/daemon/storage/storage_manager.go +++ b/client/daemon/storage/storage_manager.go @@ -813,7 +813,8 @@ func (s *storageManager) TryGC() (bool, error) { if quotaExceed || usageExceed { var bytesExceed int64 - if quotaBytesExceed > usageBytesExceed { + // only use quotaBytesExceed when s.storeOption.DiskGCThreshold > 0 + if s.storeOption.DiskGCThreshold > 0 && quotaBytesExceed > usageBytesExceed { bytesExceed = quotaBytesExceed } else { bytesExceed = usageBytesExceed