From b80b4acbe4c0df7e9496dfa120ca51f19780a9ab Mon Sep 17 00:00:00 2001
From: Gaius <gaius.qi@gmail.com>
Date: Thu, 11 May 2023 15:33:05 +0800
Subject: [PATCH] feat: optimize job new in internal (#2341)

Signed-off-by: Gaius <gaius.qi@gmail.com>
---
 internal/job/job.go | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/internal/job/job.go b/internal/job/job.go
index 137419afe..e260d0e34 100644
--- a/internal/job/job.go
+++ b/internal/job/job.go
@@ -53,16 +53,6 @@ func New(cfg *Config, queue Queue) (*Job, error) {
 	// Set logger
 	machineryv1log.Set(&MachineryLogger{})
 
-	if err := ping(&redis.UniversalOptions{
-		Addrs:      cfg.Addrs,
-		MasterName: cfg.MasterName,
-		Username:   cfg.Username,
-		Password:   cfg.Password,
-		DB:         cfg.BrokerDB,
-	}); err != nil {
-		return nil, err
-	}
-
 	if err := ping(&redis.UniversalOptions{
 		Addrs:      cfg.Addrs,
 		MasterName: cfg.MasterName,
@@ -98,8 +88,7 @@ func New(cfg *Config, queue Queue) (*Job, error) {
 }
 
 func ping(options *redis.UniversalOptions) error {
-	client := redis.NewUniversalClient(options)
-	return client.Ping(context.Background()).Err()
+	return redis.NewUniversalClient(options).Ping(context.Background()).Err()
 }
 
 func (t *Job) RegisterJob(namedJobFuncs map[string]any) error {