dragonfly/scheduler/networktopology/network_topology_test.go

841 lines
37 KiB
Go

/*
* Copyright 2023 The Dragonfly Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package networktopology
import (
"errors"
"reflect"
"strconv"
"testing"
"time"
"github.com/go-redis/redismock/v8"
"github.com/golang/mock/gomock"
"github.com/stretchr/testify/assert"
pkgredis "d7y.io/dragonfly/v2/pkg/redis"
"d7y.io/dragonfly/v2/scheduler/resource"
storagemocks "d7y.io/dragonfly/v2/scheduler/storage/mocks"
)
func Test_NewNetworkTopology(t *testing.T) {
tests := []struct {
name string
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "new network topology",
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.Equal(reflect.TypeOf(networkTopology).Elem().Name(), "networkTopology")
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, _ := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
storage := storagemocks.NewMockStorage(ctl)
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
})
}
}
func TestNetworkTopology_Serve(t *testing.T) {
tests := []struct {
name string
sleep func()
mock func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, clientMock redismock.ClientMock)
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "start network topology server",
sleep: func() {
time.Sleep(3 * time.Second)
},
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, clientMock redismock.ClientMock) {
clientMock.MatchExpectationsInOrder(true)
clientMock.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
clientMock.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
clientMock.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "averageRTT").SetVal(
strconv.FormatInt(mockProbe.RTT.Nanoseconds(), 10))
clientMock.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt").SetVal(
mockProbesCreatedAt.Format(time.RFC3339Nano))
clientMock.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "updatedAt").SetVal(
mockProbe.CreatedAt.Format(time.RFC3339Nano))
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(mockHost, true),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(nil).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
go networkTopology.Serve()
},
},
{
name: "start network topology server error",
sleep: func() {
time.Sleep(5 * time.Second)
},
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, clientMock redismock.ClientMock) {
clientMock.MatchExpectationsInOrder(true)
clientMock.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetErr(
errors.New("get probed count keys error"))
clientMock.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
clientMock.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
clientMock.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "averageRTT").SetVal(
strconv.FormatInt(mockProbe.RTT.Nanoseconds(), 10))
clientMock.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt").SetVal(
mockProbesCreatedAt.Format(time.RFC3339Nano))
clientMock.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "updatedAt").SetVal(
mockProbe.CreatedAt.Format(time.RFC3339Nano))
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(mockHost, true),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(nil).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
go networkTopology.Serve()
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, clientMock := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
hostManager := resource.NewMockHostManager(ctl)
storage := storagemocks.NewMockStorage(ctl)
tc.mock(res.EXPECT(), hostManager, hostManager.EXPECT(), storage.EXPECT(), clientMock)
mockNetworkTopologyConfig.CollectInterval = 2 * time.Second
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
tc.sleep()
networkTopology.Stop()
})
}
}
func TestNewNetworkTopology_Has(t *testing.T) {
tests := []struct {
name string
mock func(mockRDBClient redismock.ClientMock)
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "network topology between src host and destination host exists",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectExists(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)).SetVal(1)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.True(networkTopology.Has(mockSeedHost.ID, mockHost.ID))
},
},
{
name: "network topology between src host and destination host does not exist",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectExists(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)).SetVal(0)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.False(networkTopology.Has(mockSeedHost.ID, mockHost.ID))
},
},
{
name: "check network topology between src host and destination host exist error",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectExists(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)).SetErr(
errors.New("check network topology between src host and destination host exist error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.False(networkTopology.Has(mockSeedHost.ID, mockHost.ID))
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, mockRDBClient := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
storage := storagemocks.NewMockStorage(ctl)
tc.mock(mockRDBClient)
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
mockRDBClient.ClearExpect()
})
}
}
func TestNewNetworkTopology_Store(t *testing.T) {
tests := []struct {
name string
mock func(mockRDBClient redismock.ClientMock)
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "network topology between src host and destination host exists",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectExists(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)).SetVal(1)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Store(mockSeedHost.ID, mockHost.ID))
},
},
{
name: "network topology between src host and destination host does not exist",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectExists(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)).SetVal(0)
mockRDBClient.Regexp().ExpectHSet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt", `.*`).SetVal(1)
mockRDBClient.ExpectSet(pkgredis.MakeProbedCountKeyInScheduler(mockHost.ID), 0, 0).SetVal("ok")
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Store(mockSeedHost.ID, mockHost.ID))
},
},
{
name: "set createdAt error when network topology between src host and destination host does not exist",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectExists(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)).SetVal(0)
mockRDBClient.Regexp().ExpectHSet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt", `.*`).SetErr(errors.New("set createdAt error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.EqualError(networkTopology.Store(mockSeedHost.ID, mockHost.ID), "set createdAt error")
},
},
{
name: "set probed count error when network topology between src host and destination host does not exist",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectExists(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)).SetVal(0)
mockRDBClient.Regexp().ExpectHSet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt", `.*`).SetVal(1)
mockRDBClient.ExpectSet(pkgredis.MakeProbedCountKeyInScheduler(mockHost.ID), 0, 0).SetErr(errors.New("set probed count error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.EqualError(networkTopology.Store(mockSeedHost.ID, mockHost.ID), "set probed count error")
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, mockRDBClient := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
storage := storagemocks.NewMockStorage(ctl)
tc.mock(mockRDBClient)
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
mockRDBClient.ClearExpect()
})
}
}
func TestNewNetworkTopology_DeleteHost(t *testing.T) {
tests := []struct {
name string
deleteKeys []string
mock func(mockRDBClient redismock.ClientMock, keys []string)
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "delete host",
deleteKeys: []string{pkgredis.MakeProbedAtKeyInScheduler(mockHost.ID),
pkgredis.MakeProbedCountKeyInScheduler(mockHost.ID),
pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID),
pkgredis.MakeProbesKeyInScheduler(mockSeedHost.ID, mockHost.ID)},
mock: func(mockRDBClient redismock.ClientMock, keys []string) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockHost.ID, "*")).SetVal([]string{})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler("*", mockHost.ID)).SetVal([]string{keys[2]})
mockRDBClient.ExpectKeys(pkgredis.MakeProbesKeyInScheduler(mockHost.ID, "*")).SetVal([]string{})
mockRDBClient.ExpectKeys(pkgredis.MakeProbesKeyInScheduler("*", mockHost.ID)).SetVal([]string{keys[3]})
mockRDBClient.ExpectDel(keys...).SetVal(4)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.DeleteHost(mockHost.ID))
},
},
{
name: "get source network topology keys error",
deleteKeys: []string{},
mock: func(mockRDBClient redismock.ClientMock, keys []string) {
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockHost.ID, "*")).SetErr(
errors.New("get source network topology keys error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.EqualError(networkTopology.DeleteHost(mockHost.ID), "get source network topology keys error")
},
},
{
name: "get destination network topology keys error",
deleteKeys: []string{},
mock: func(mockRDBClient redismock.ClientMock, keys []string) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockHost.ID, "*")).SetVal([]string{})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler("*", mockHost.ID)).SetErr(
errors.New("get destination network topology keys error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.EqualError(networkTopology.DeleteHost(mockHost.ID), "get destination network topology keys error")
},
},
{
name: "get source probes keys error",
deleteKeys: []string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)},
mock: func(mockRDBClient redismock.ClientMock, keys []string) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockHost.ID, "*")).SetVal([]string{})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler("*", mockHost.ID)).SetVal([]string{keys[0]})
mockRDBClient.ExpectKeys(pkgredis.MakeProbesKeyInScheduler(mockHost.ID, "*")).SetErr(
errors.New("get source probes keys error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.EqualError(networkTopology.DeleteHost(mockHost.ID), "get source probes keys error")
},
},
{
name: "get destination probes keys error",
deleteKeys: []string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)},
mock: func(mockRDBClient redismock.ClientMock, keys []string) {
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockHost.ID, "*")).SetVal([]string{})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler("*", mockHost.ID)).SetVal([]string{keys[0]})
mockRDBClient.ExpectKeys(pkgredis.MakeProbesKeyInScheduler(mockHost.ID, "*")).SetVal([]string{})
mockRDBClient.ExpectKeys(pkgredis.MakeProbesKeyInScheduler("*", mockHost.ID)).SetErr(
errors.New("get destination probes keys error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.EqualError(networkTopology.DeleteHost(mockHost.ID), "get destination probes keys error")
},
},
{
name: "delete network topology and probes error",
deleteKeys: []string{pkgredis.MakeProbedAtKeyInScheduler(mockHost.ID),
pkgredis.MakeProbedCountKeyInScheduler(mockHost.ID),
pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID),
pkgredis.MakeProbesKeyInScheduler(mockSeedHost.ID, mockHost.ID)},
mock: func(mockRDBClient redismock.ClientMock, keys []string) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockHost.ID, "*")).SetVal([]string{})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler("*", mockHost.ID)).SetVal([]string{keys[2]})
mockRDBClient.ExpectKeys(pkgredis.MakeProbesKeyInScheduler(mockHost.ID, "*")).SetVal([]string{})
mockRDBClient.ExpectKeys(pkgredis.MakeProbesKeyInScheduler("*", mockHost.ID)).SetVal([]string{keys[3]})
mockRDBClient.ExpectDel(keys...).SetErr(errors.New("delete network topology and probes error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.EqualError(networkTopology.DeleteHost(mockHost.ID), "delete network topology and probes error")
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, mockRDBClient := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
storage := storagemocks.NewMockStorage(ctl)
tc.mock(mockRDBClient, tc.deleteKeys)
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
mockRDBClient.ClearExpect()
})
}
}
func TestNewNetworkTopology_Probes(t *testing.T) {
tests := []struct {
name string
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "loads probes interface",
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
ps := networkTopology.Probes(mockSeedHost.ID, mockHost.ID)
probes := ps.(*probes)
assert.Equal(probes.config.QueueLength, 5)
assert.NotNil(probes.rdb)
assert.Equal(probes.srcHostID, mockSeedHost.ID)
assert.Equal(probes.destHostID, mockHost.ID)
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, _ := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
storage := storagemocks.NewMockStorage(ctl)
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
})
}
}
func TestNewNetworkTopology_ProbedCount(t *testing.T) {
tests := []struct {
name string
mock func(mockRDBClient redismock.ClientMock)
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "get probed count",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectGet(pkgredis.MakeProbedCountKeyInScheduler(mockHost.ID)).SetVal(strconv.Itoa(mockProbedCount))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
probedCount, err := networkTopology.ProbedCount(mockHost.ID)
assert.NoError(err)
assert.EqualValues(probedCount, mockProbedCount)
},
},
{
name: "get probed count error",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectGet(pkgredis.MakeProbedCountKeyInScheduler(mockHost.ID)).SetErr(errors.New("get probed count error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
_, err = networkTopology.ProbedCount(mockHost.ID)
assert.EqualError(err, "get probed count error")
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, mockRDBClient := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
storage := storagemocks.NewMockStorage(ctl)
tc.mock(mockRDBClient)
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
mockRDBClient.ClearExpect()
})
}
}
func TestNewNetworkTopology_ProbedAt(t *testing.T) {
tests := []struct {
name string
mock func(mockRDBClient redismock.ClientMock)
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "get the time when the host was last probed",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectGet(pkgredis.MakeProbedAtKeyInScheduler(mockHost.ID)).SetVal(mockProbe.CreatedAt.Format(time.RFC3339Nano))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
probedAt, err := networkTopology.ProbedAt(mockHost.ID)
assert.NoError(err)
assert.True(mockProbe.CreatedAt.Equal(probedAt))
},
},
{
name: "get the time when the host was last probed error",
mock: func(mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectGet(pkgredis.MakeProbedAtKeyInScheduler(mockHost.ID)).SetErr(errors.New("get the time when the host was last probed error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
_, err = networkTopology.ProbedAt(mockHost.ID)
assert.EqualError(err, "get the time when the host was last probed error")
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, mockRDBClient := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
storage := storagemocks.NewMockStorage(ctl)
tc.mock(mockRDBClient)
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
mockRDBClient.ClearExpect()
})
}
}
func TestNetworkTopology_Snapshot(t *testing.T) {
tests := []struct {
name string
mock func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock)
expect func(t *testing.T, networkTopology NetworkTopology, err error)
}{
{
name: "writes the current network topology to the storage",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "averageRTT").SetVal(
strconv.FormatInt(mockProbe.RTT.Nanoseconds(), 10))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt").SetVal(
mockProbesCreatedAt.Format(time.RFC3339Nano))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "updatedAt").SetVal(
mockProbe.CreatedAt.Format(time.RFC3339Nano))
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(mockHost, true),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(nil).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "get probed count keys error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetErr(
errors.New("get probed count keys error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.EqualError(networkTopology.Snapshot(), "get probed count keys error")
},
},
{
name: "parse probed count keys in scheduler error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{"foo"})
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "get network topology keys error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetErr(
errors.New("get network topology keys error"))
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "parse network topology keys in scheduler error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{"foo"})
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(nil).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "construct destination hosts for network topology error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(nil, false),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(nil).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "get averageRTT error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "averageRTT").SetErr(
errors.New("get averageRTT error"))
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(mockHost, true),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(nil).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "get createdAt error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "averageRTT").SetVal(
strconv.FormatInt(mockProbe.RTT.Nanoseconds(), 10))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt").SetErr(
errors.New("get createdAt error"))
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(mockHost, true),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(nil).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "get updatedAt error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "averageRTT").SetVal(
strconv.FormatInt(mockProbe.RTT.Nanoseconds(), 10))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt").SetVal(
mockProbesCreatedAt.Format(time.RFC3339Nano))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "updatedAt").SetErr(
errors.New("get updatedAt error"))
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(mockHost, true),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(nil).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "construct source hosts for network topology error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "averageRTT").SetVal(
strconv.FormatInt(mockProbe.RTT.Nanoseconds(), 10))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt").SetVal(
mockProbesCreatedAt.Format(time.RFC3339Nano))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "updatedAt").SetVal(
mockProbe.CreatedAt.Format(time.RFC3339Nano))
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(mockHost, true),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(nil, false),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
{
name: "inserts the network topology into csv file error",
mock: func(mr *resource.MockResourceMockRecorder, hostManager resource.HostManager,
mh *resource.MockHostManagerMockRecorder, ms *storagemocks.MockStorageMockRecorder, mockRDBClient redismock.ClientMock) {
mockRDBClient.MatchExpectationsInOrder(true)
mockRDBClient.ExpectKeys(pkgredis.MakeProbedCountKeyInScheduler("*")).SetVal(
[]string{pkgredis.MakeProbedCountKeyInScheduler(mockSeedHost.ID)})
mockRDBClient.ExpectKeys(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, "*")).SetVal(
[]string{pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID)})
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "averageRTT").SetVal(
strconv.FormatInt(mockProbe.RTT.Nanoseconds(), 10))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "createdAt").SetVal(
mockProbesCreatedAt.Format(time.RFC3339Nano))
mockRDBClient.ExpectHGet(pkgredis.MakeNetworkTopologyKeyInScheduler(mockSeedHost.ID, mockHost.ID), "updatedAt").SetVal(
mockProbe.CreatedAt.Format(time.RFC3339Nano))
gomock.InOrder(
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockHost.ID)).Return(mockHost, true),
mr.HostManager().Return(hostManager).Times(1),
mh.Load(gomock.Eq(mockSeedHost.ID)).Return(mockSeedHost, true),
ms.CreateNetworkTopology(gomock.Any()).Return(errors.New("inserts the network topology into csv file error")).Times(1),
)
},
expect: func(t *testing.T, networkTopology NetworkTopology, err error) {
assert := assert.New(t)
assert.NoError(err)
assert.NoError(networkTopology.Snapshot())
},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctl := gomock.NewController(t)
defer ctl.Finish()
rdb, mockRDBClient := redismock.NewClientMock()
res := resource.NewMockResource(ctl)
hostManager := resource.NewMockHostManager(ctl)
storage := storagemocks.NewMockStorage(ctl)
tc.mock(res.EXPECT(), hostManager, hostManager.EXPECT(), storage.EXPECT(), mockRDBClient)
networkTopology, err := NewNetworkTopology(mockNetworkTopologyConfig, rdb, res, storage)
tc.expect(t, networkTopology, err)
mockRDBClient.ClearExpect()
})
}
}