chore: Remove redundant object sorting

- The Solver Graph performs sorting.
  So the applier & destroyer don't need to.
This commit is contained in:
Karl Isenberg 2022-02-14 22:48:45 -08:00
parent 2b7c073a37
commit c1f572dc4c
2 changed files with 0 additions and 6 deletions

View File

@ -6,7 +6,6 @@ package apply
import (
"context"
"fmt"
"sort"
"time"
"k8s.io/apimachinery/pkg/api/meta"
@ -28,7 +27,6 @@ import (
"sigs.k8s.io/cli-utils/pkg/inventory"
"sigs.k8s.io/cli-utils/pkg/object"
"sigs.k8s.io/cli-utils/pkg/object/validation"
"sigs.k8s.io/cli-utils/pkg/ordering"
)
const defaultPollInterval = 2 * time.Second
@ -93,7 +91,6 @@ func (a *Applier) prepareObjects(localInv inventory.InventoryInfo, localObjs obj
if err != nil {
return nil, nil, err
}
sort.Sort(ordering.SortableUnstructureds(localObjs))
return localObjs, pruneObjs, nil
}

View File

@ -13,7 +13,6 @@ package prune
import (
"context"
"sort"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/meta"
@ -27,7 +26,6 @@ import (
"sigs.k8s.io/cli-utils/pkg/common"
"sigs.k8s.io/cli-utils/pkg/inventory"
"sigs.k8s.io/cli-utils/pkg/object"
"sigs.k8s.io/cli-utils/pkg/ordering"
)
// Pruner implements GetPruneObjs to calculate which objects to prune and Prune
@ -233,7 +231,6 @@ func (p *Pruner) GetPruneObjs(
}
objs = append(objs, pruneObj)
}
sort.Sort(sort.Reverse(ordering.SortableUnstructureds(objs)))
return objs, nil
}