feat: copy labels from upstream

Signed-off-by: Hans Knecht <Hans.Knecht@missionlane.com>
This commit is contained in:
Hans Knecht 2021-06-11 16:18:29 -04:00
parent 8137a25b13
commit 8555f8250a
No known key found for this signature in database
GPG Key ID: 7EA54829461C9E7E
4 changed files with 21 additions and 0 deletions

View File

@ -160,6 +160,8 @@ spec:
cmd: "hey -z 2m -q 5 -c 2 -host app.example.com http://gateway-proxy.gloo-system"
```
*Note: when using upstreamRef the following fields are copied over from the original upstream: `Labels, SslConfig, CircuitBreakers, ConnectionConfig, UseHttp2, InitialStreamWindowSize`*
Save the above resource as podinfo-canary.yaml and then apply it:
```bash

View File

@ -18,6 +18,7 @@ type Upstream struct {
type UpstreamSpec struct {
Kube *KubeUpstream `json:"kube,omitempty"`
Labels map[string]string `json:"Labels,omitempty"`
SslConfig *UpstreamSslConfig `json:"sslConfig,omitempty"`
CircuitBreakers *CircuitBreakerConfig `json:"circuitBreakers,omitempty"`
ConnectionConfig *ConnectionConfig `json:"connectionConfig,omitempty"`

View File

@ -294,6 +294,13 @@ func (in *UpstreamSpec) DeepCopyInto(out *UpstreamSpec) {
*out = new(KubeUpstream)
(*in).DeepCopyInto(*out)
}
if in.Labels != nil {
in, out := &in.Labels, &out.Labels
*out = make(map[string]string, len(*in))
for key, val := range *in {
(*out)[key] = val
}
}
if in.SslConfig != nil {
in, out := &in.SslConfig, &out.SslConfig
*out = new(UpstreamSslConfig)

View File

@ -276,6 +276,7 @@ func (gr *GlooRouter) getGlooUpstreamKubeService(canary *flaggerv1.Canary, svc *
if glooUpstreamWithConfig != nil {
configSpec := glooUpstreamWithConfig.Spec
upstreamSpec = gloov1.UpstreamSpec{
Labels: configSpec.Labels,
SslConfig: configSpec.SslConfig,
CircuitBreakers: configSpec.CircuitBreakers,
ConnectionConfig: configSpec.ConnectionConfig,
@ -293,10 +294,20 @@ func (gr *GlooRouter) getGlooUpstreamKubeService(canary *flaggerv1.Canary, svc *
Selector: svc.Spec.Selector,
}
upstreamLabels := make(map[string]string)
if upstreamSpec.Labels != nil {
for k, v := range upstreamSpec.Labels { // Order not specified
if _, ok := upstreamLabels[k]; !ok {
upstreamLabels[k] = v
}
}
}
return &gloov1.Upstream{
ObjectMeta: metav1.ObjectMeta{
Name: upstreamName,
Namespace: canary.Namespace,
Labels: upstreamLabels,
OwnerReferences: []metav1.OwnerReference{
*metav1.NewControllerRef(canary, schema.GroupVersionKind{
Group: flaggerv1.SchemeGroupVersion.Group,