spec: add validation rules for (namespace)names

api/v2alpha1/helmrelease_types.go

@@ -50,11 +50,17 @@ type HelmReleaseSpec struct {
 
 	// ReleaseName used for the Helm release. Defaults to a composition of
 	// '[TargetNamespace-]Name'.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=53
+	// +kubebuilder:validation:Optional
 	// +optional
 	ReleaseName string `json:"releaseName,omitempty"`
 
 	// TargetNamespace to target when performing operations for the HelmRelease.
 	// Defaults to the namespace of the HelmRelease.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=63
+	// +kubebuilder:validation:Optional
 	// +optional
 	TargetNamespace string `json:"targetNamespace,omitempty"`
 

api/v2alpha1/reference_types.go

@@ -29,10 +29,15 @@ type CrossNamespaceObjectReference struct {
 	Kind string `json:"kind,omitempty"`
 
 	// Name of the referent.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=253
 	// +required
 	Name string `json:"name"`
 
 	// Namespace of the referent.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=63
+	// +kubebuilder:validation:Optional
 	// +optional
 	Namespace string `json:"namespace,omitempty"`
 }
@@ -47,6 +52,8 @@ type ValuesReference struct {
 
 	// Name of the values referent. Should reside in the same namespace as the
 	// referring resource.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=253
 	// +required
 	Name string `json:"name"`
 

config/crd/bases/helm.toolkit.fluxcd.io_helmreleases.yaml

@@ -79,9 +79,13 @@ spec:
                             type: string
                           name:
                             description: Name of the referent.
+                            maxLength: 253
+                            minLength: 1
                             type: string
                           namespace:
                             description: Namespace of the referent.
+                            maxLength: 63
+                            minLength: 1
                             type: string
                         required:
                         - name
@@ -185,6 +189,8 @@ spec:
               releaseName:
                 description: ReleaseName used for the Helm release. Defaults to a
                   composition of '[TargetNamespace-]Name'.
+                maxLength: 53
+                minLength: 1
                 type: string
               rollback:
                 description: Rollback holds the configuration for Helm rollback actions
@@ -224,6 +230,8 @@ spec:
               targetNamespace:
                 description: TargetNamespace to target when performing operations
                   for the HelmRelease. Defaults to the namespace of the HelmRelease.
+                maxLength: 63
+                minLength: 1
                 type: string
               test:
                 description: Test holds the configuration for Helm test actions for
@@ -355,6 +363,8 @@ spec:
                     name:
                       description: Name of the values referent. Should reside in the
                         same namespace as the referring resource.
+                      maxLength: 253
+                      minLength: 1
                       type: string
                     targetPath:
                       description: TargetPath is the YAML dot notation path the value

docs/spec/v2alpha1/helmreleases.md

@@ -28,11 +28,17 @@ type HelmReleaseSpec struct {
 
 	// ReleaseName used for the Helm release. Defaults to a composition of
 	// '[TargetNamespace-]Name'.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=53
+	// +kubebuilder:validation:Optional
 	// +optional
 	ReleaseName string `json:"releaseName,omitempty"`
 
 	// TargetNamespace to target when performing operations for the HelmRelease.
 	// Defaults to the namespace of the HelmRelease.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=63
+	// +kubebuilder:validation:Optional
 	// +optional
 	TargetNamespace string `json:"targetNamespace,omitempty"`
 
@@ -327,10 +333,15 @@ type CrossNamespaceObjectReference struct {
 	Kind string `json:"kind,omitempty"`
 
 	// Name of the referent.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=253
 	// +required
 	Name string `json:"name"`
 
 	// Namespace of the referent.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=63
+	// +kubebuilder:validation:Optional
 	// +optional
 	Namespace string `json:"namespace,omitempty"`
 }
@@ -345,6 +356,8 @@ type ValuesReference struct {
 
 	// Name of the values referent. Should reside in the same namespace as the
 	// referring resource.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=253
 	// +required
 	Name string `json:"name"`