From a35a8a97073c9021f002a85eee054cf77c4701c2 Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Wed, 28 Oct 2020 13:44:05 +0100 Subject: [PATCH] Do not requeue when chart is not ready As the watcher should trigger a reconciliation once the artifact is available. Signed-off-by: Hidde Beydals --- controllers/helmrelease_controller.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/controllers/helmrelease_controller.go b/controllers/helmrelease_controller.go index 1502e2d..93ff591 100644 --- a/controllers/helmrelease_controller.go +++ b/controllers/helmrelease_controller.go @@ -226,7 +226,9 @@ func (r *HelmReleaseReconciler) reconcile(ctx context.Context, log logr.Logger, msg := fmt.Sprintf("HelmChart '%s/%s' is not ready", hc.GetNamespace(), hc.GetName()) r.event(hr, hr.Status.LastAttemptedRevision, events.EventSeverityInfo, msg) log.Info(msg) - return v2.HelmReleaseNotReady(hr, v2.ArtifactFailedReason, msg), ctrl.Result{Requeue: true}, nil + // Do not requeue, when the artifact is created the watcher should trigger a + // reconciliation. + return v2.HelmReleaseNotReady(hr, v2.ArtifactFailedReason, msg), ctrl.Result{Requeue: false}, nil } // Check dependencies