Add disableWait property on Helm uninstall
This commit changes the default behavior of the Helm uninstall action to wait for all resources to be deleted, and introduces a `.spec.uninstall.disableWait` flag to disable this behavior. Signed-off-by: Samuel Torres <samuelpirestorres@gmail.com>
This commit is contained in:
parent
dedffc0557
commit
7d6c0f7c47
|
@ -754,6 +754,11 @@ type Uninstall struct {
|
|||
// release as deleted, but retain the release history.
|
||||
// +optional
|
||||
KeepHistory bool `json:"keepHistory,omitempty"`
|
||||
|
||||
// DisableWait disables waiting for all the resources to be deleted after
|
||||
// a Helm uninstall is performed.
|
||||
// +optional
|
||||
DisableWait bool `json:"disableWait,omitempty"`
|
||||
}
|
||||
|
||||
// GetTimeout returns the configured timeout for the Helm uninstall action, or
|
||||
|
|
|
@ -497,6 +497,10 @@ spec:
|
|||
description: DisableHooks prevents hooks from running during the
|
||||
Helm rollback action.
|
||||
type: boolean
|
||||
disableWait:
|
||||
description: DisableWait disables waiting for all the resources
|
||||
to be deleted after a Helm uninstall is performed.
|
||||
type: boolean
|
||||
keepHistory:
|
||||
description: KeepHistory tells Helm to remove all associated resources
|
||||
and mark the release as deleted, but retain the release history.
|
||||
|
|
|
@ -1755,6 +1755,19 @@ bool
|
|||
release as deleted, but retain the release history.</p>
|
||||
</td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td>
|
||||
<code>disableWait</code><br>
|
||||
<em>
|
||||
bool
|
||||
</em>
|
||||
</td>
|
||||
<td>
|
||||
<em>(Optional)</em>
|
||||
<p>DisableWait disables waiting for all the resources to be deleted after
|
||||
a Helm uninstall is performed.</p>
|
||||
</td>
|
||||
</tr>
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
|
|
|
@ -375,6 +375,7 @@ func (r *Runner) Uninstall(hr v2.HelmRelease) error {
|
|||
uninstall.Timeout = hr.Spec.GetUninstall().GetTimeout(hr.GetTimeout()).Duration
|
||||
uninstall.DisableHooks = hr.Spec.GetUninstall().DisableHooks
|
||||
uninstall.KeepHistory = hr.Spec.GetUninstall().KeepHistory
|
||||
uninstall.Wait = !hr.Spec.GetUninstall().DisableWait
|
||||
|
||||
_, err := uninstall.Run(hr.GetReleaseName())
|
||||
return wrapActionErr(r.logBuffer, err)
|
||||
|
|
Loading…
Reference in New Issue