fluxcd
/
helm-controller
mirror of https://github.com/fluxcd/helm-controller.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: use HelmRelease max history for rollback remediation 

Signed-off-by: Stevo Slavic <sslavic@gmail.com>
This commit is contained in:
Stevo Slavic 2025-02-11 15:17:29 +01:00
parent 8dfcca2cb0
commit dda1d355b7
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/action/rollback.go
View File

@ -65,6 +65,7 @@ func newRollback(config *helmaction.Configuration, obj *v2.HelmRelease, opts []R
rollback.Force = obj.GetRollback().Force rollback.Force = obj.GetRollback().Force
rollback.Recreate = obj.GetRollback().Recreate rollback.Recreate = obj.GetRollback().Recreate
rollback.CleanupOnFail = obj.GetRollback().CleanupOnFail rollback.CleanupOnFail = obj.GetRollback().CleanupOnFail
rollback.MaxHistory = obj.GetMaxHistory()
for _, opt := range opts { for _, opt := range opts {
opt(rollback) opt(rollback)

1
internal/action/rollback_test.go
View File

@ -49,6 +49,7 @@ func Test_newRollback(t *testing.T) {
g.Expect(got).ToNot(BeNil()) g.Expect(got).ToNot(BeNil())
g.Expect(got.Timeout).To(Equal(obj.Spec.Rollback.Timeout.Duration)) g.Expect(got.Timeout).To(Equal(obj.Spec.Rollback.Timeout.Duration))
g.Expect(got.Force).To(Equal(obj.Spec.Rollback.Force)) g.Expect(got.Force).To(Equal(obj.Spec.Rollback.Force))
g.Expect(got.MaxHistory).To(Equal(obj.GetMaxHistory()))
}) })
t.Run("rollback to version", func(t *testing.T) { t.Run("rollback to version", func(t *testing.T) {