From ee651bf8b70cef25c74ef66d5670554dcf9de934 Mon Sep 17 00:00:00 2001 From: Matheus Pimenta Date: Sat, 9 Aug 2025 18:36:43 +0100 Subject: [PATCH] Remove tautology Signed-off-by: Matheus Pimenta --- internal/reconcile/atomic_release.go | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/internal/reconcile/atomic_release.go b/internal/reconcile/atomic_release.go index 457a28a..07eacf2 100644 --- a/internal/reconcile/atomic_release.go +++ b/internal/reconcile/atomic_release.go @@ -283,16 +283,11 @@ func (r *AtomicRelease) Reconcile(ctx context.Context, req *Request) error { conditions.MarkReconciling(req.Object, meta.ProgressingWithRetryReason, "%s", conditions.GetMessage(req.Object, meta.ReadyCondition)) return ErrMustRequeue } - // Check if retries have exhausted after remediation for early - // stall condition detection. - if remediation != nil && remediation.RetriesExhausted(req.Object) { - conditions.MarkStalled(req.Object, "RetriesExceeded", "Failed to %s after %d attempt(s)", - req.Object.Status.LastAttemptedReleaseAction, req.Object.GetActiveRemediation().GetFailureCount(req.Object)) - return ErrExceededMaxRetries - } - conditions.Delete(req.Object, meta.ReconcilingCondition) - return nil + // Retries have exhausted after remediation for early stall condition detection. + conditions.MarkStalled(req.Object, "RetriesExceeded", "Failed to %s after %d attempt(s)", + req.Object.Status.LastAttemptedReleaseAction, req.Object.GetActiveRemediation().GetFailureCount(req.Object)) + return ErrExceededMaxRetries } // Append the type to the set of action types we have performed.