Remove interval default value from CRDs
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
This commit is contained in:
parent
074072d0de
commit
d57c09a0dd
|
@ -57,7 +57,6 @@ type ProviderSpec struct {
|
|||
Type string `json:"type"`
|
||||
|
||||
// Interval at which to reconcile the Provider with its Secret references.
|
||||
// +kubebuilder:default="600s"
|
||||
// +kubebuilder:validation:Type=string
|
||||
// +kubebuilder:validation:Pattern="^([0-9]+(\\.[0-9]+)?(ms|s|m|h))+$"
|
||||
// +optional
|
||||
|
|
|
@ -51,7 +51,6 @@ type ReceiverSpec struct {
|
|||
Type string `json:"type"`
|
||||
|
||||
// Interval at which to reconcile the Receiver with its Secret references.
|
||||
// +kubebuilder:default="600s"
|
||||
// +kubebuilder:validation:Type=string
|
||||
// +kubebuilder:validation:Pattern="^([0-9]+(\\.[0-9]+)?(ms|s|m|h))+$"
|
||||
// +optional
|
||||
|
|
|
@ -250,7 +250,6 @@ spec:
|
|||
maxLength: 2048
|
||||
type: string
|
||||
interval:
|
||||
default: 600s
|
||||
description: Interval at which to reconcile the Provider with its
|
||||
Secret references.
|
||||
pattern: ^([0-9]+(\.[0-9]+)?(ms|s|m|h))+$
|
||||
|
|
|
@ -254,7 +254,6 @@ spec:
|
|||
type: string
|
||||
type: array
|
||||
interval:
|
||||
default: 600s
|
||||
description: Interval at which to reconcile the Receiver with its
|
||||
Secret references.
|
||||
pattern: ^([0-9]+(\.[0-9]+)?(ms|s|m|h))+$
|
||||
|
|
|
@ -74,7 +74,6 @@ func TestProviderReconciler_Reconcile(t *testing.T) {
|
|||
|
||||
g.Expect(conditions.Has(resultP, meta.ReconcilingCondition)).To(BeFalse())
|
||||
g.Expect(controllerutil.ContainsFinalizer(resultP, apiv1.NotificationFinalizer)).To(BeTrue())
|
||||
g.Expect(resultP.Spec.Interval.Duration).To(BeIdenticalTo(10 * time.Minute))
|
||||
})
|
||||
|
||||
t.Run("fails with secret not found error", func(t *testing.T) {
|
||||
|
|
|
@ -102,7 +102,6 @@ func TestReceiverReconciler_Reconcile(t *testing.T) {
|
|||
|
||||
g.Expect(conditions.Has(resultR, meta.ReconcilingCondition)).To(BeFalse())
|
||||
g.Expect(controllerutil.ContainsFinalizer(resultR, apiv1.NotificationFinalizer)).To(BeTrue())
|
||||
g.Expect(resultR.Spec.Interval.Duration).To(BeIdenticalTo(10 * time.Minute))
|
||||
})
|
||||
|
||||
t.Run("fails with secret not found error", func(t *testing.T) {
|
||||
|
|
Loading…
Reference in New Issue