fluxcd
/
source-controller
mirror of https://github.com/fluxcd/source-controller.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

helm: return ErrExternal when loading index fails 

Loading index can fail due to network error. Return ErrExternal typed
error for it.

Signed-off-by: Sunny <darkowlzz@protonmail.com>
This commit is contained in:
Sunny 2022-12-19 08:57:00 +00:00
parent 8018b450a1
commit 869a9df6e9
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/helm/repository/chart_repository.go
View File

@ -156,6 +156,11 @@ func newChartRepository() *ChartRepository {
// to be a semver.Constraints compatible string. If version is empty, the latest // to be a semver.Constraints compatible string. If version is empty, the latest
// stable version will be returned and prerelease versions will be ignored. // stable version will be returned and prerelease versions will be ignored.
func (r *ChartRepository) GetChartVersion(name, ver string) (*repo.ChartVersion, error) { func (r *ChartRepository) GetChartVersion(name, ver string) (*repo.ChartVersion, error) {
// See if we already have the index in cache or try to load it.
if err := r.StrategicallyLoadIndex(); err != nil {
return nil, &ErrExternal{Err: err}
}
cv, err := r.getChartVersion(name, ver) cv, err := r.getChartVersion(name, ver)
if err != nil { if err != nil {
return nil, &ErrReference{Err: err} return nil, &ErrReference{Err: err}
@ -164,11 +169,6 @@ func (r *ChartRepository) GetChartVersion(name, ver string) (*repo.ChartVersion,
} }
func (r *ChartRepository) getChartVersion(name, ver string) (*repo.ChartVersion, error) { func (r *ChartRepository) getChartVersion(name, ver string) (*repo.ChartVersion, error) {
// See if we already have the index in cache or try to load it.
if err := r.StrategicallyLoadIndex(); err != nil {
return nil, err
}
r.RLock() r.RLock()
defer r.RUnlock() defer r.RUnlock()