internal/helm: ErrChartReference on local load err
If a local reference does not contain a path to a valid file, returning `ErrChartReference` is more correct to signal the reference is invalid. This also indirectly causes the reconciler to signal a Suspend, as the source or resource requires a change before a reattempt might be successful. Signed-off-by: Hidde Beydals <hello@hidde.co>
This commit is contained in:
parent
999215b4c0
commit
8c1a74d588
|
@ -77,10 +77,10 @@ func (b *localChartBuilder) Build(ctx context.Context, ref Reference, p string,
|
|||
// to a chart
|
||||
curMeta, err := LoadChartMetadata(localRef.Path)
|
||||
if err != nil {
|
||||
return nil, &BuildError{Reason: ErrChartPull, Err: err}
|
||||
return nil, &BuildError{Reason: ErrChartReference, Err: err}
|
||||
}
|
||||
if err = curMeta.Validate(); err != nil {
|
||||
return nil, &BuildError{Reason: ErrChartPull, Err: err}
|
||||
return nil, &BuildError{Reason: ErrChartReference, Err: err}
|
||||
}
|
||||
|
||||
result := &Build{}
|
||||
|
|
Loading…
Reference in New Issue