From 0bd5b95c892b677476bef1defb51e77a8a2cca51 Mon Sep 17 00:00:00 2001 From: Sunny Date: Tue, 28 Nov 2023 11:39:32 +0000 Subject: [PATCH 1/2] Rename make target `build` to `manager` Due to the existence of a BUILD_DIR called `build` the `build` make target never works. Rename the make target as `manager`, in alignment with other makefiles in other repos and not conflict with the `build` directory. Signed-off-by: Sunny --- Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index d1995d5c..e3690098 100644 --- a/Makefile +++ b/Makefile @@ -61,9 +61,10 @@ ifeq ($(shell uname -s),Darwin) ENVTEST_ARCH=amd64 endif -all: build +all: manager -build: ## Build manager binary +# Build manager binary +manager: generate fmt vet go build $(GO_STATIC_FLAGS) -o $(BUILD_DIR)/bin/manager main.go KUBEBUILDER_ASSETS?="$(shell $(ENVTEST) --arch=$(ENVTEST_ARCH) use -i $(ENVTEST_KUBERNETES_VERSION) --bin-dir=$(ENVTEST_ASSETS_DIR) -p path)" From cc3d495aa9f6008578a82187241e5552b1f04286 Mon Sep 17 00:00:00 2001 From: Stefan Prodan Date: Fri, 3 May 2024 09:38:14 +0300 Subject: [PATCH 2/2] ci: Print controller logs after e2e run Signed-off-by: Stefan Prodan --- .github/workflows/e2e.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index fae80517..cb229f79 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -46,6 +46,11 @@ jobs: SKIP_COSIGN_VERIFICATION: true CREATE_CLUSTER: false run: make e2e + - name: Print controller logs + if: always() + continue-on-error: true + run: | + kubectl -n source-system logs -l app=source-controller kind-linux-arm64: # Hosted on Equinix