fluxcd
/
source-controller
mirror of https://github.com/fluxcd/source-controller.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #280 from runyontr/runyontr-279 

Properly escape outer loop for present dependency
This commit is contained in:
Hidde Beydals 2021-02-02 16:50:06 +01:00 committed by GitHub
parent eca08f87c2 8428054575
commit ec05e0e172
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
controllers/helmchart_controller.go
View File

@ -539,11 +539,15 @@ func (r *HelmChartReconciler) reconcileFromTarballArtifact(ctx context.Context,
var dwr []*helm.DependencyWithRepository var dwr []*helm.DependencyWithRepository
for _, dep := range reqs { for _, dep := range reqs {
// Exclude existing dependencies // Exclude existing dependencies
found := false
for _, existing := range deps { for _, existing := range deps {
if existing.Name() == dep.Name { if existing.Name() == dep.Name {
continue found = true
} }
} }
if found {
continue
}
// Continue loop if file scheme detected // Continue loop if file scheme detected
if dep.Repository == "" || strings.HasPrefix(dep.Repository, "file://") { if dep.Repository == "" || strings.HasPrefix(dep.Repository, "file://") {