From fa00ec8fc796c6578645ac012d7b14a625a08c3d Mon Sep 17 00:00:00 2001 From: Paulo Gomes Date: Mon, 7 Feb 2022 15:08:03 +0000 Subject: [PATCH] Migrate from deprecated ginkgo async testing https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md\#removed-async-testing Signed-off-by: Paulo Gomes --- controllers/suite_test.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/controllers/suite_test.go b/controllers/suite_test.go index 9520bcbb..f0c41170 100644 --- a/controllers/suite_test.go +++ b/controllers/suite_test.go @@ -56,6 +56,8 @@ var exampleCA []byte var ctx context.Context var cancel context.CancelFunc +const timeout = time.Second * 30 + func TestAPIs(t *testing.T) { RegisterFailHandler(Fail) @@ -64,7 +66,12 @@ func TestAPIs(t *testing.T) { []Reporter{printer.NewlineReporter{}}) } -var _ = BeforeSuite(func(done Done) { +var _ = BeforeSuite(func() { + done := make(chan interface{}) + go func() { + close(done) + }() + logf.SetLogger( zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)), ) @@ -153,7 +160,7 @@ var _ = BeforeSuite(func(done Done) { k8sClient = k8sManager.GetClient() Expect(k8sClient).ToNot(BeNil()) - close(done) + Eventually(done, timeout).Should(BeClosed()) }, 60) var _ = AfterSuite(func() {