fluxcd
/
source-controller
mirror of https://github.com/fluxcd/source-controller.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: Use proper timeouts in gitrepository and helmrepository tests 

I assume using "interval" for timeouts was an accident and "timeout" was
actually meant to be used. This also fixes flakiness of tests.

Signed-off-by: Alexander Block <ablock84@gmail.com>
This commit is contained in:
Alexander Block 2022-04-25 14:28:10 +02:00
parent 7c8b175258
commit fa09aa2a39
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
controllers/gitrepository_controller_test.go
View File

@ -434,7 +434,7 @@ func TestGitRepositoryReconciler_reconcileSource_authStrategy(t *testing.T) {
}, },
Spec: sourcev1.GitRepositorySpec{ Spec: sourcev1.GitRepositorySpec{
Interval: metav1.Duration{Duration: interval}, Interval: metav1.Duration{Duration: interval},
Timeout: &metav1.Duration{Duration: interval}, Timeout: &metav1.Duration{Duration: timeout},
}, },
} }
@ -653,7 +653,7 @@ func TestGitRepositoryReconciler_reconcileSource_checkoutStrategy(t *testing.T)
}, },
Spec: sourcev1.GitRepositorySpec{ Spec: sourcev1.GitRepositorySpec{
Interval: metav1.Duration{Duration: interval}, Interval: metav1.Duration{Duration: interval},
Timeout: &metav1.Duration{Duration: interval}, Timeout: &metav1.Duration{Duration: timeout},
URL: server.HTTPAddress() + repoPath, URL: server.HTTPAddress() + repoPath,
Reference: tt.reference, Reference: tt.reference,
}, },
@ -1517,7 +1517,7 @@ func TestGitRepositoryReconciler_ConditionsUpdate(t *testing.T) {
URL: server.HTTPAddress() + repoPath, URL: server.HTTPAddress() + repoPath,
GitImplementation: sourcev1.GoGitImplementation, GitImplementation: sourcev1.GoGitImplementation,
Interval: metav1.Duration{Duration: interval}, Interval: metav1.Duration{Duration: interval},
Timeout: &metav1.Duration{Duration: interval}, Timeout: &metav1.Duration{Duration: timeout},
}, },
} }

2
controllers/helmrepository_controller_test.go
View File

@ -440,7 +440,7 @@ func TestHelmRepositoryReconciler_reconcileSource(t *testing.T) {
}, },
Spec: sourcev1.HelmRepositorySpec{ Spec: sourcev1.HelmRepositorySpec{
Interval: metav1.Duration{Duration: interval}, Interval: metav1.Duration{Duration: interval},
Timeout: &metav1.Duration{Duration: interval}, Timeout: &metav1.Duration{Duration: timeout},
}, },
} }