source-controller/pkg
Paulo Gomes bfa4e38b84
libgit2: dispose connections in SubTransport.Close
The average SubTransport lifecycle encompass two Actions calls. Previously,
it was attempted to share the same connection across both calls. That did
not work as some Git Servers do not support multiple sessions from the same
connection. The implementation was not fully transitioned into the
"one connection per action" model, which led to connection being leaked.

The transition to RW mutex was to avoid the unnecessary blocking in the
goroutine at the start of the second action call.

It is worth mentioning that now when the context is done,  the client level
resources (connection) will also be freed. This ensures that SSH connections
will not outlive the subtransport.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
2022-06-08 19:39:50 +01:00
..
azure build: properly wire integration tests 2022-03-11 10:43:35 +01:00
gcp test: use `T.TempDir` to create temporary test directory 2022-04-29 23:01:39 +08:00
git libgit2: dispose connections in SubTransport.Close 2022-06-08 19:39:50 +01:00
minio Remove minio region 2022-05-10 14:28:54 +01:00
sourceignore test: use `T.TempDir` to create temporary test directory 2022-04-29 23:01:39 +08:00