Remove unnecessary imports and superfluous type checks (#525)

This commit is contained in:
Kevin Moore 2021-10-05 08:39:00 -07:00 committed by GitHub
parent 276fd5a70f
commit 151fa904b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
11 changed files with 6 additions and 15 deletions

View File

@ -15,7 +15,6 @@
/// Dart implementation of the gRPC helloworld.Greeter client. /// Dart implementation of the gRPC helloworld.Greeter client.
import 'package:grpc/grpc.dart'; import 'package:grpc/grpc.dart';
import 'package:helloworld/src/generated/helloworld.pb.dart';
import 'package:helloworld/src/generated/helloworld.pbgrpc.dart'; import 'package:helloworld/src/generated/helloworld.pbgrpc.dart';
Future<void> main(List<String> args) async { Future<void> main(List<String> args) async {

View File

@ -15,7 +15,6 @@
/// Dart implementation of the gRPC helloworld.Greeter server. /// Dart implementation of the gRPC helloworld.Greeter server.
import 'package:grpc/grpc.dart'; import 'package:grpc/grpc.dart';
import 'package:helloworld/src/generated/helloworld.pb.dart';
import 'package:helloworld/src/generated/helloworld.pbgrpc.dart'; import 'package:helloworld/src/generated/helloworld.pbgrpc.dart';
class GreeterService extends GreeterServiceBase { class GreeterService extends GreeterServiceBase {

View File

@ -15,9 +15,8 @@
/// Dart implementation of the gRPC helloworld.Greeter client. /// Dart implementation of the gRPC helloworld.Greeter client.
import 'dart:io'; import 'dart:io';
import 'package:grpc/grpc.dart';
import 'package:helloworld/src/generated/helloworld.pb.dart'; import 'package:grpc/grpc.dart';
import 'package:helloworld/src/generated/helloworld.pbgrpc.dart'; import 'package:helloworld/src/generated/helloworld.pbgrpc.dart';
Future<void> main(List<String> args) async { Future<void> main(List<String> args) async {

View File

@ -15,9 +15,8 @@
/// Dart implementation of the gRPC helloworld.Greeter server. /// Dart implementation of the gRPC helloworld.Greeter server.
import 'dart:io'; import 'dart:io';
import 'package:grpc/grpc.dart';
import 'package:helloworld/src/generated/helloworld.pb.dart'; import 'package:grpc/grpc.dart';
import 'package:helloworld/src/generated/helloworld.pbgrpc.dart'; import 'package:helloworld/src/generated/helloworld.pbgrpc.dart';
class GreeterService extends GreeterServiceBase { class GreeterService extends GreeterServiceBase {

View File

@ -18,7 +18,6 @@ import 'dart:math' show Random;
import 'package:grpc/grpc.dart'; import 'package:grpc/grpc.dart';
import 'common.dart'; import 'common.dart';
import 'generated/route_guide.pb.dart';
import 'generated/route_guide.pbgrpc.dart'; import 'generated/route_guide.pbgrpc.dart';
class Client { class Client {

View File

@ -18,7 +18,6 @@ import 'dart:math' show atan2, cos, max, min, pi, sin, sqrt;
import 'package:grpc/grpc.dart' as grpc; import 'package:grpc/grpc.dart' as grpc;
import 'common.dart'; import 'common.dart';
import 'generated/route_guide.pb.dart';
import 'generated/route_guide.pbgrpc.dart'; import 'generated/route_guide.pbgrpc.dart';
class RouteGuideService extends RouteGuideServiceBase { class RouteGuideService extends RouteGuideServiceBase {

View File

@ -19,6 +19,7 @@ import 'dart:typed_data';
import 'package:collection/collection.dart'; import 'package:collection/collection.dart';
import 'package:grpc/grpc.dart'; import 'package:grpc/grpc.dart';
import 'generated/empty.pb.dart'; import 'generated/empty.pb.dart';
import 'generated/messages.pb.dart'; import 'generated/messages.pb.dart';
import 'generated/test.pbgrpc.dart'; import 'generated/test.pbgrpc.dart';
@ -152,8 +153,7 @@ class Tester {
/// * call was successful /// * call was successful
/// * response is non-null /// * response is non-null
Future<void> emptyUnary() async { Future<void> emptyUnary() async {
final response = await client.emptyCall(Empty()); await client.emptyCall(Empty());
if (response is! Empty) throw 'Expected Empty response.';
} }
/// This test verifies that gRPC requests marked as cacheable use GET verb /// This test verifies that gRPC requests marked as cacheable use GET verb

View File

@ -1,12 +1,13 @@
@TestOn('vm') @TestOn('vm')
import 'dart:async'; import 'dart:async';
import 'package:grpc/grpc.dart' as grpc; import 'package:grpc/grpc.dart' as grpc;
import 'package:grpc/service_api.dart';
import 'package:grpc/src/client/channel.dart'; import 'package:grpc/src/client/channel.dart';
import 'package:grpc/src/client/connection.dart'; import 'package:grpc/src/client/connection.dart';
import 'package:grpc/src/client/http2_connection.dart'; import 'package:grpc/src/client/http2_connection.dart';
import 'package:http2/http2.dart'; import 'package:http2/http2.dart';
import 'package:test/test.dart'; import 'package:test/test.dart';
import 'common.dart'; import 'common.dart';
class TestClient extends grpc.Client { class TestClient extends grpc.Client {

View File

@ -1,7 +1,6 @@
import 'dart:async'; import 'dart:async';
import 'package:grpc/grpc.dart'; import 'package:grpc/grpc.dart';
import 'package:grpc/src/client/interceptor.dart';
import 'package:http2/transport.dart'; import 'package:http2/transport.dart';
import 'package:test/test.dart'; import 'package:test/test.dart';

View File

@ -18,7 +18,6 @@ import 'dart:convert';
import 'dart:io' show HttpStatus; import 'dart:io' show HttpStatus;
import 'package:grpc/grpc.dart'; import 'package:grpc/grpc.dart';
import 'package:grpc/src/client/call.dart';
import 'package:grpc/src/client/http2_connection.dart'; import 'package:grpc/src/client/http2_connection.dart';
import 'package:grpc/src/generated/google/rpc/status.pb.dart'; import 'package:grpc/src/generated/google/rpc/status.pb.dart';
import 'package:grpc/src/shared/status.dart'; import 'package:grpc/src/shared/status.dart';

View File

@ -13,7 +13,6 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
@TestOn('!browser') @TestOn('!browser')
import 'package:grpc/grpc.dart'; import 'package:grpc/grpc.dart';
import 'package:grpc/grpc_or_grpcweb.dart'; import 'package:grpc/grpc_or_grpcweb.dart';
import 'package:test/test.dart'; import 'package:test/test.dart';
@ -28,7 +27,6 @@ void main() {
port: port, port: port,
transportSecure: false, transportSecure: false,
); );
expect(channel is ClientChannel, isTrue);
expect(channel.host, equals(host)); expect(channel.host, equals(host));
expect(channel.port, equals(port)); expect(channel.port, equals(port));
expect(channel.options.credentials.isSecure, isFalse); expect(channel.options.credentials.isSecure, isFalse);