grpc
/
grpc-dart
mirror of https://github.com/grpc/grpc-dart.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't print from server (#212) 

Co-authored-by: Vyacheslav Egorov <vegorov@google.com>
This commit is contained in:
Sigurd Meldgaard 2020-10-29 12:57:47 +01:00 committed by GitHub
parent 7ea15a8160
commit 21529c6be7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/src/server/server.dart
View File

@ -105,8 +105,10 @@ class ConnectionServer {
// timeout. // timeout.
connection.incomingStreams.listen((stream) { connection.incomingStreams.listen((stream) {
handler = serveStream_(stream); handler = serveStream_(stream);
}, onError: (error) { }, onError: (error, stackTrace) {
print('Connection error: $error'); if (error is Error) {
Zone.current.handleUncaughtError(error, stackTrace);
}
}, onDone: () { }, onDone: () {
// TODO(sigurdm): This is not correct behavior in the presence of // TODO(sigurdm): This is not correct behavior in the presence of
// half-closed tcp streams. // half-closed tcp streams.
@ -175,11 +177,11 @@ class Server extends ConnectionServer {
final connection = ServerTransportConnection.viaSocket(socket, final connection = ServerTransportConnection.viaSocket(socket,
settings: http2ServerSettings); settings: http2ServerSettings);
serveConnection(connection); serveConnection(connection);
}, onError: _printSocketError); }, onError: (error, stackTrace) {
if (error is Error) {
Zone.current.handleUncaughtError(error, stackTrace);
} }
});
void _printSocketError(Object error) {
print('Socket error: $error');
} }
@visibleForTesting @visibleForTesting