grpc
/
grpc-experiments
mirror of https://github.com/grpc/grpc-experiments.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

grpc-zpages: remove DI param from channelz service (#309) 

`@Optional` was supposed to make this param optional, but it appears
we are hitting this issue while building internally:
https://github.com/angular/angular/issues/24533
This commit is contained in:
zpencer 2018-08-09 14:43:06 -07:00 committed by GitHub
parent 2d5ed88f1c
commit 1364e0e20c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
grpc-zpages/web/channelzui/src/app/channelz.service.ts
View File

@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Injectable, Optional } from "@angular/core";
import { Injectable } from "@angular/core";
import { Observable } from "rxjs";
import { environment } from "../environments/environment";
@ -39,13 +39,10 @@ export class ChannelzService {
xsrfMeta: {};
client: any;
// Because this class is @Injectable, angular takes care of DI for parameters.
// This means we can not provide a default parameter value.
// The parameter is either injected or it is null.
constructor(@Optional() private grpcRemoteAddr:string) {
constructor() {
this.xsrfMeta = ChannelzService.genXsrfMeta();
this.client = new proto.grpc.channelz.v1.ChannelzClient(
grpcRemoteAddr == null ? environment.grpcRemoteAddr : grpcRemoteAddr);
environment.grpcRemoteAddr);
}
private static genXsrfMeta(): any {