mirror of https://github.com/grpc/grpc-go.git
xds: require router filter when filters are empty (#4553)
This commit is contained in:
parent
633fbe4dfe
commit
00ae0c57cc
|
@ -255,9 +255,6 @@ func (cs *configSelector) generateHash(rpcInfo iresolver.RPCInfo, hashPolicies [
|
|||
}
|
||||
|
||||
func (cs *configSelector) newInterceptor(rt *route, cluster *routeCluster) (iresolver.ClientInterceptor, error) {
|
||||
if len(cs.httpFilterConfig) == 0 {
|
||||
return nil, nil
|
||||
}
|
||||
interceptors := make([]iresolver.ClientInterceptor, 0, len(cs.httpFilterConfig))
|
||||
for _, filter := range cs.httpFilterConfig {
|
||||
if router.IsRouterFilter(filter.Filter) {
|
||||
|
|
|
@ -1197,6 +1197,11 @@ func (s) TestXDSResolverHTTPFilters(t *testing.T) {
|
|||
selectErr string
|
||||
newStreamErr string
|
||||
}{
|
||||
{
|
||||
name: "empty filters",
|
||||
ldsFilters: []xdsclient.HTTPFilter{},
|
||||
selectErr: "no router filter present",
|
||||
},
|
||||
{
|
||||
name: "no router filter",
|
||||
ldsFilters: []xdsclient.HTTPFilter{
|
||||
|
|
Loading…
Reference in New Issue