xds: require router filter when filters are empty (#4553)

This commit is contained in:
Aliaksandr Mianzhynski 2021-06-17 20:23:18 +03:00 committed by GitHub
parent 633fbe4dfe
commit 00ae0c57cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions

View File

@ -255,9 +255,6 @@ func (cs *configSelector) generateHash(rpcInfo iresolver.RPCInfo, hashPolicies [
}
func (cs *configSelector) newInterceptor(rt *route, cluster *routeCluster) (iresolver.ClientInterceptor, error) {
if len(cs.httpFilterConfig) == 0 {
return nil, nil
}
interceptors := make([]iresolver.ClientInterceptor, 0, len(cs.httpFilterConfig))
for _, filter := range cs.httpFilterConfig {
if router.IsRouterFilter(filter.Filter) {

View File

@ -1197,6 +1197,11 @@ func (s) TestXDSResolverHTTPFilters(t *testing.T) {
selectErr string
newStreamErr string
}{
{
name: "empty filters",
ldsFilters: []xdsclient.HTTPFilter{},
selectErr: "no router filter present",
},
{
name: "no router filter",
ldsFilters: []xdsclient.HTTPFilter{