grpc
/
grpc-go
mirror of https://github.com/grpc/grpc-go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

weightedroundrobin: Remove nil embedded SubConn from endpointWeight (#8297)

This commit is contained in:
Arjan Singh Bal 2025-05-07 23:42:11 +05:30 committed by GitHub
parent 41095aeec6
commit 35aea9cd90
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
balancer/weightedroundrobin/balancer.go
View File

@ -497,7 +497,6 @@ func (p *picker) start(stopPicker *grpcsync.Event) {
// that listener. // that listener.
type endpointWeight struct { type endpointWeight struct {
// The following fields are immutable. // The following fields are immutable.
balancer.SubConn
logger *grpclog.PrefixLogger logger *grpclog.PrefixLogger
target string target string
metricsRecorder estats.MetricsRecorder metricsRecorder estats.MetricsRecorder
@ -527,7 +526,7 @@ type endpointWeight struct {
func (w *endpointWeight) OnLoadReport(load *v3orcapb.OrcaLoadReport) { func (w *endpointWeight) OnLoadReport(load *v3orcapb.OrcaLoadReport) {
if w.logger.V(2) { if w.logger.V(2) {
w.logger.Infof("Received load report for subchannel %v: %v", w.SubConn, load) w.logger.Infof("Received load report for subchannel %v: %v", w.pickedSC, load)
} }
// Update weights of this endpoint according to the reported load. // Update weights of this endpoint according to the reported load.
utilization := load.ApplicationUtilization utilization := load.ApplicationUtilization
@ -536,7 +535,7 @@ func (w *endpointWeight) OnLoadReport(load *v3orcapb.OrcaLoadReport) {
} }
if utilization == 0 || load.RpsFractional == 0 { if utilization == 0 || load.RpsFractional == 0 {
if w.logger.V(2) { if w.logger.V(2) {
w.logger.Infof("Ignoring empty load report for subchannel %v", w.SubConn) w.logger.Infof("Ignoring empty load report for subchannel %v", w.pickedSC)
} }
return return
} }
@ -547,7 +546,7 @@ func (w *endpointWeight) OnLoadReport(load *v3orcapb.OrcaLoadReport) {
errorRate := load.Eps / load.RpsFractional errorRate := load.Eps / load.RpsFractional
w.weightVal = load.RpsFractional / (utilization + errorRate*w.cfg.ErrorUtilizationPenalty) w.weightVal = load.RpsFractional / (utilization + errorRate*w.cfg.ErrorUtilizationPenalty)
if w.logger.V(2) { if w.logger.V(2) {
w.logger.Infof("New weight for subchannel %v: %v", w.SubConn, w.weightVal) w.logger.Infof("New weight for subchannel %v: %v", w.pickedSC, w.weightVal)
} }
w.lastUpdated = internal.TimeNow() w.lastUpdated = internal.TimeNow()