From 6d6c0413c7b6bbda96451e0700b3ed6a820ca9c5 Mon Sep 17 00:00:00 2001 From: Zeming YU Date: Thu, 25 Jul 2019 10:54:14 -0700 Subject: [PATCH] test: fix race reading while incrementing (#2935) Swap the `<-done` and `if numConns < 2` to make sure `numConns++` happens before read --- clientconn_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clientconn_test.go b/clientconn_test.go index 7beb5879a..13727ee8a 100644 --- a/clientconn_test.go +++ b/clientconn_test.go @@ -232,10 +232,10 @@ func (s) TestDialWaitsForServerSettingsAndFails(t *testing.T) { if err != context.DeadlineExceeded { t.Fatalf("DialContext(_) = %v; want context.DeadlineExceeded", err) } + <-done if numConns < 2 { t.Fatalf("dial attempts: %v; want > 1", numConns) } - <-done } // 1. Client connects to a server that doesn't send preface.